Re: 回复: [PATCH v1 03/11] MdePkg/Acpi64: Add _PSD/_CPC/State Coordination Types macros

["PierreGondois" <pierre.gondois@arm.com>]

Hello Liming,

On 5/6/23 03:25, gaoliming wrote:
> Pierre:
> 
>> -----邮件原件-----
>> 发件人: pierre.gondois@arm.com <pierre.gondois@arm.com>
>> 发送时间: 2023年5月5日 21:17
>> 收件人: devel@edk2.groups.io
>> 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
>> <leif@nuviainc.com>; Sami Mujawar <sami.mujawar@arm.com>; Michael D
>> Kinney <michael.d.kinney@intel.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
>> 主题: [PATCH v1 03/11] MdePkg/Acpi64: Add _PSD/_CPC/State Coordination
>> Types macros
>>
>> From: Pierre Gondois <pierre.gondois@arm.com>
>>
>> Add macros for:
>> - _PSD version
>> - _CPC version
>> - C-state/T-state/P-state Coordination Types
>>
>> These objects were present in previous ACPI specification version,
>> but are only added to the latest availbable version (6.4).
>>
>> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
>> ---
>>   MdePkg/Include/IndustryStandard/Acpi64.h | 25
>> +++++++++++++++++++++++-
>>   1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
>> b/MdePkg/Include/IndustryStandard/Acpi64.h
>> index 575ca0430c13..e3c128d7548d 100644
>> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
>> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
>> @@ -2,7 +2,7 @@
>>     ACPI 6.4 definitions from the ACPI Specification Revision 6.4 Jan,
> 2021.
>>
>>     Copyright (c) 2017 - 2022, Intel Corporation. All rights reserved.<BR>
>> -  Copyright (c) 2019 - 2021, ARM Ltd. All rights reserved.<BR>
>> +  Copyright (c) 2019 - 2023, Arm Ltd. All rights reserved.<BR>
>>
> I see other source files all use ARM Ltd. Is it required to be updated to
> Arm Ltd?

I think the name of the company was rebranded from ARM to Arm in 2017,
so I've been asked to change the the copyright name when we update the copyright
year ...


> 
> Thanks
> Liming
>>     SPDX-License-Identifier: BSD-2-Clause-Patent
>>   **/
>> @@ -17,6 +17,29 @@
>>   //
>>   #pragma pack(1)
>>
>> +///
>> +/// C-state/T-state/P-state Coordination Types
>> +/// Cf. s8.3 Power, Performance, and Throttling State Dependencies
>> +///
>> +#define EFI_ACPI_6_4_AML_STATE_COORD_TYPE_SW_ALL  0xFC
>> +#define EFI_ACPI_6_4_AML_STATE_COORD_TYPE_SW_ANY  0xFD
>> +#define EFI_ACPI_6_4_AML_STATE_COORD_TYPE_HW_ALL  0xFE
>> +
>> +///
>> +/// _PSD Revision
>> +/// Cf. s8.4.6.5 _PSD (P-State Dependency)
>> +///
>> +#define EFI_ACPI_6_4_AML_PSD_REVISION_V0  0
>> +
>> +///
>> +/// _CPC Revision
>> +/// Cf. s8.4.7.1 _CPC (Continuous Performance Control)
>> +///
>> +#define EFI_ACPI_6_4_AML_CPC_REVISION_V0  0
>> +#define EFI_ACPI_6_4_AML_CPC_REVISION_V1  1
>> +#define EFI_ACPI_6_4_AML_CPC_REVISION_V2  2
>> +#define EFI_ACPI_6_4_AML_CPC_REVISION_V3  3
>> +
>>   ///
>>   /// ACPI 6.4 Generic Address Space definition
>>   ///
>> --
>> 2.25.1
> 
> 
>