From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.72]) by mx.groups.io with SMTP id smtpd.web08.5426.1657789612629369181 for ; Thu, 14 Jul 2022 02:06:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=vgiNEbBd; spf=pass (domain: arm.com, ip: 40.107.20.72, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fDXeinMYAS29ISGLL1nwefr6tVzZLC57yyQ2nYYBIITOKoLxBxUyh50b0PSb1cWYITyHEz4Zl3fJYVH+RvW1mv3IErIOo8iSJjZphz+L+145XxflDzJL/Zg7QvDALuLHi7S+Ybl0KbrcG65CivlApYttk6fj5rhYQRCpUJXswwu9oVnXjHwYh/a6uAHRgA2/1oy8Cx9g8iBd+s1Q5eYTmGZ5layEYSDkwU+Jn2102M4N1SWsNhuGwwRibdDHm2gaSR135KHcmCUGwhYqiWMJbgbsh9uNxHrVJm0mvs9jGUY8wGcwmcUpDlHNIvnCKZe/+UGrj0xu8P30CGeRhbc2mQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZChRE1G3O/xlWekiW0mtvi+7dM38bzWsvgGcpi6UIxA=; b=cZNbDVF0HiUrIBim7DddxQJAoiaUBLEr4pgrQX8VgnC8//kxRgQPNhkGxzMAdJdn6fq7Z/IfN9rK5PT11simNpv29B06Uuxd4PcF9RNan4RoyJcySkA+DR4QVz2VD97byLJ6WpxDooE/Cz56yBsrBbGpIUu4cCyDDmEXJ58BN/q3adQ/syzGqlbf1ulhTZe2122ffyU8kCMql56ivhgBHUCfm6ruYLESwTLL9HobspFlgX+Lss7qCt6TSwqoAeMuL3LEu6l1eD9QLlPx48gfOG7sMdczxlDRU1VsCJWZjQSi1emhjpj9PDqaF/ETaexNvo8OkxTMGsp8qm4anXvh7Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZChRE1G3O/xlWekiW0mtvi+7dM38bzWsvgGcpi6UIxA=; b=vgiNEbBdoX3gFTfjRS51sPmyqwnW/rHluJRfUrKRLiHVq0gGx7oXzDmuEvGzBjAWCkfAmx5x3ISEtS57U0g9U2bTdLq2E4MosFq6KObQIKX99K64EFrwR6778UcOIbxUBnl4W5iryPcis57qFAfOKMyCGReF+wf/d9bMt4kOQl8= Received: from AM6P192CA0049.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::26) by VE1PR08MB5806.eurprd08.prod.outlook.com (2603:10a6:800:1b1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 14 Jul 2022 09:06:48 +0000 Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::c0) by AM6P192CA0049.outlook.office365.com (2603:10a6:209:82::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 09:06:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 09:06:47 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Thu, 14 Jul 2022 09:06:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b72c048eb4bcd35e X-CR-MTA-TID: 64aa7808 Received: from c3b7f338c06f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79BC4B4E-C0A6-49A2-AC84-7A67C83B5171.1; Thu, 14 Jul 2022 09:06:36 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c3b7f338c06f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:06:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MG/3IveprVAcIwKMqcbAYH+dVaL5GfBtEkdGYlG6Dorypn7OyMLgVXmObxq+j+O0Q9w7wumZoNMaKCODwmUmUm4VFOkZo95MbV/V+g4OHx5ZHWcL4IJTRKnaiKMB6sD74hSicPCeLnkhyFoxs4ME7KPSDs3xJJAAqPUiLSs34m1kkC1f0a3ylA2dd8B5ECt84kqJA1foR9Zc45tWwq6SDBmRXBi34svIvk1aQ0OmakzKqGaKju8vCU0oA87aDh/b64N8aRsx+wKBE92ZtMJme2G+tMnd6ZBmzIL2gXFH4PjIXjwzm286zzl/mI90C28BJ9VUmkEVqXkQksbeCs51Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZChRE1G3O/xlWekiW0mtvi+7dM38bzWsvgGcpi6UIxA=; b=SgDgQug9uLrJTjKWLSRWpZF0eX8ICfUkFeBpe7yxMJPmBRAjVY3fbURGtJcEmRBZ2lwzWZVNw8QnJw+N5XlZQ6Yh0Dt2LKrIMKYGvQerGPLuSBFgeVRg+aryUl3/PrUa1qK72msjOfq1QxQDVUleCTlZ4i1+nQ9gJ4wAQU1bLWCC9S/FJvR7edJLvn+bk/LnibstZZAsvXNN60XEv05XnEUjHDb1JvZuDUuEaZtaz22JPbl8PdUg6tVjmAmG/bpabvA5cBo9Fg3OtdheH/o8WhvDtP6laS2Ss3PsqXcXP+2yLSWtW/S+5GPH7OfsJisMxm3h/lx712Vq6fQx3zWIJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZChRE1G3O/xlWekiW0mtvi+7dM38bzWsvgGcpi6UIxA=; b=vgiNEbBdoX3gFTfjRS51sPmyqwnW/rHluJRfUrKRLiHVq0gGx7oXzDmuEvGzBjAWCkfAmx5x3ISEtS57U0g9U2bTdLq2E4MosFq6KObQIKX99K64EFrwR6778UcOIbxUBnl4W5iryPcis57qFAfOKMyCGReF+wf/d9bMt4kOQl8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by HE1PR08MB2665.eurprd08.prod.outlook.com (2603:10a6:7:39::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 09:06:31 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%5]) with mapi id 15.20.5438.012; Thu, 14 Jul 2022 09:06:31 +0000 Message-ID: <277daca6-2449-4a0d-3e96-205e730c36bc@arm.com> Date: Thu, 14 Jul 2022 10:06:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib To: devel@edk2.groups.io, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Pierre Gondois CC: vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220712144047.3080-1-sami.mujawar@arm.com> <20220712144047.3080-9-sami.mujawar@arm.com> <1701A22D591971D9.31468@groups.io> From: "Sami Mujawar" In-Reply-To: <1701A22D591971D9.31468@groups.io> X-ClientProxiedBy: LO4P265CA0190.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6b58638f-f8ff-4061-a1b1-08da65782ebc X-MS-TrafficTypeDiagnostic: HE1PR08MB2665:EE_|VE1EUR03FT011:EE_|VE1PR08MB5806:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dj12N8a6AILJvrL/BaWVgMkSF5FTPSJ5nnbABBmF/wmzpQCliRudNqZZu/gE0UZX63nmnJl2wFLGkp6JpmfWZ/DUaMHEBE4Yxp5unRdUJam/W19PRY+izpnFLJ7xUNgY4pY5W5HzXnfcB25JGNzwpCUTX7PgPoMWhgUx75WPbhIbRJBwNvQijY/UfH0LkHmoQ0wz65AwqKnBJDQ56FXIy518kyOmMi4hmdsjuLc61xBxCxKd+S7s2g3lF6BmrkE63wBW04yUPvHLa6DOP6T5TK80VKjIJELyJQhIYU7+Izq0BvRrqFeih1yJfVlswj0tlPo6z5tmILDh42tWWaXyGOzdszTgbVUIOr8FT8klb1B7T1fivtE2HkkJWo61AIrFQ+azMt118MpdZIBPvmPjwrpNbJYwvytED9HwT7zwkef7BXSFae2tfKt4GXA8eM0IguTLTeD2w73jN9EHz5CURjYMIphsuNeGR87X9c/epv6/avHx/tc+Xn8dfbX5DMTJ62V9BM7aXcgs6Q52HP2hjLluFVKkTfG8xrS1iaHz8mP+j/Uzm0o2xIFX9rSGKaTCmPHu/QYd4k26vhsERl3lX+7cO79dV7Ckyi5VSHffCkrTcaTy1/5tTx+3RKOjPa7en67hyTIUO8RtJ7tHW1pY9ciYCm6QywzA6SIsyLMtElHGBYzkioUmoOJ86HJ66t7uL3WPdJBndysCBGeUmvJ2sH3CppTYwm8bGMkmrAoHKrWJsEAIKzXwjO991mn5mfk85CTO7OHRggYdaqrTB4IbqpS6nGufN1NOLNT/ChL/ncr2M25PwwVUSCcozJIBy5un3UMePCVTdym4w56cp2sYlLkpKsPRIQoYFqkWlWInzDXM42J7z6fPGwYDktVJRPzVsI0wwiWHQfW+d03U2L/qWpgdFVweP3IjAKPXR1v/rY8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(39860400002)(376002)(136003)(396003)(316002)(83380400001)(6512007)(2616005)(186003)(53546011)(2906002)(36756003)(31686004)(38100700002)(41300700001)(6506007)(478600001)(31696002)(5660300002)(8936002)(6636002)(86362001)(44832011)(110136005)(4326008)(66946007)(6486002)(966005)(66556008)(26005)(66476007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2665 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 95c75da2-d3ad-4323-2fad-08da6578247a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qb3LmEg9fTqCNUEdNll5312xR8QqqasCQ9RNZdBEQk99Eq9f1h2PZMunBpKr/5Nxy4R7NmKsDyIA1GA6aNUod5UA6SphbygDZ3wII/szHDJT3FVBaN5rchK1zMck6bX25ojdCvfpd4R/Cjba9z/Xo49fgM/vGY8pHTn2Z7hIHRrg+inglWZVGVG86neRs5LXpks+EWh8+JiqYBJLUw0S3tvcjMhRHu2QiWFRztEAzCqOHz1VMxt/2jOImFgSYsPydAQAVcvbKODHGayYNAwcQ2rdwBxMWrY886nOJ71+wJovuabo7drIxM8mAAlIhauVGKt7OSvius3QSea9iSRTjhxXJsQyY6RmrFU69kwxEvH2z2g3LsDCOXGlLUOA7YpTjTzJ7NT27Joy+i9x+5N/J6Rh+ppHwCxultLX7BxPJAeSkGdj/jtvGsY7mA/0WMnZEKI9E3bUEPX8mFQKY+ZqwLC4GvMmk9ymaVLkWwb+bUJk9DtdXjwnYeROfdFs7A7gp9qlp5TtMiVn4lAqy0J7ChvGhhXTaQcJE2yTqETmECOf6CiV3qAntP6PlJAdU9TaMn/pPDd1elRIvEhPPkaR5338PZ9OeJuRWeUVsJgKfrxLK6prsADz3N0ec1oT1abd9pIMXe2S5AYVoSLMBVkXvxHc7vTamZWWNxg5nHZyyXhfHFLHle/Zw2m1K7L8mAN4SxFM5KsL0UXELb+8wLeMPqnKpsME5GWc2wF3dWeH4bBIXyqKC7GEwL+H4fqCUymYGELj5j1K7Sb9RIWGotBTVM1RQC+thwnmBnC1Y/PGjgS6kMnRFcKbaDPqLcNUjzJz6y4B6gdErRI1ECFz897h0ztWk7xOTihXdphFawdS9oO0r9kueAiu8BZDA4H30lP0V8bR5V1mJSdmRtImM73FDqHXeLWRVriskv3OxdvYasY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(36840700001)(40470700004)(46966006)(47076005)(53546011)(6486002)(110136005)(2906002)(186003)(336012)(2616005)(83380400001)(70586007)(70206006)(40460700003)(81166007)(6512007)(8936002)(86362001)(26005)(31696002)(82740400003)(356005)(40480700001)(316002)(6506007)(36756003)(4326008)(82310400005)(6636002)(36860700001)(44832011)(41300700001)(5660300002)(966005)(8676002)(478600001)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:06:47.9847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b58638f-f8ff-4061-a1b1-08da65782ebc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5806 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Nhi, Looks like the file=20 Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in=20 upstream edk2-platforms. See=20 https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/Ampe= reAltraPkg Regards, Sami Mujawar On 14/07/2022 08:40 am, Sami Mujawar via groups.io wrote: > Hi Nhi, > > I will do that no problem. However, we really need an edk2-platforms=20 > CI to catch such issues. > > Regards, > > Sami Mujawar > > On 14/07/2022 04:34 am, Nhi Pham wrote: >> Hi Sami, >> >> Could you help update for=20 >> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? >> >> Thanks, >> Nhi >> >> On 12/07/2022 21:40, Sami Mujawar wrote: >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3479 >>> >>> Add an instance for the library class VariableFlashInfoLib that >>> was recently introduced in MdeModulePkg. This allows the variable >>> driver to build successfully as it has a dependency on this >>> library class. >>> >>> Signed-off-by: Sami Mujawar >>> --- >>> =C2=A0 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + >>> =C2=A0 1 file changed, 1 insertion(+) >>> >>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc=20 >>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >>> index=20 >>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14= d1727bd4fe4=20 >>> 100644 >>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc >>> @@ -154,6 +154,7 @@ [LibraryClasses.common] >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLi= bNull.inf=20 >>> >>> =C2=A0 !endif >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicy= Lib.inf=20 >>> >>> +=20 >>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/Base= VariableFlashInfoLib.inf >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va= riablePolicyHelperLib.inf=20 >>> >>> =C2=A0 =C2=A0=C2=A0=C2=A0 # > > >=20 > >