public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jeshua Smith <jeshuas@nvidia.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC
Date: Wed, 02 Aug 2023 23:48:41 -0700	[thread overview]
Message-ID: <27848.1691045321153861434@groups.io> (raw)
In-Reply-To: <DM6PR12MB3371A39406EB01906B9016C2DB0AA@DM6PR12MB3371.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Hi Jeshua,
Thank you for the feedback.

On Tue, Aug 1, 2023 at 08:38 AM, Jeshua Smith wrote:

> 
> This comment in the code looks wrong:
> 
> + // TRBE Interrupt is PPI 13 on FVP model.
> + TrbeInterrupt = 31;

I will fix this in the v2 series.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107521): https://edk2.groups.io/g/devel/message/107521
Mute This Topic: https://groups.io/mt/100347409/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1124 bytes --]

  reply	other threads:[~2023-08-03  6:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 10:31 [edk2-devel] [PATCH edk2-platforms v1 0/3] Platform/ARM: Add dynamic CPU node, TRBE & ETE support to FVP Sami Mujawar
2023-07-25 10:31 ` [edk2-devel] [PATCH edk2-platforms v1 1/3] Platform/ARM: Add dynamic CPU node generation for FVP Sami Mujawar
2023-07-25 10:31 ` [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC Sami Mujawar
2023-08-01 15:38   ` Jeshua Smith via groups.io
2023-08-03  6:48     ` Sami Mujawar [this message]
     [not found]   ` <17774C7EDBBD6733.29484@groups.io>
2023-08-02 21:48     ` Jeshua Smith via groups.io
2023-08-03  7:00       ` Sami Mujawar
2023-08-03 14:47         ` Jeshua Smith via groups.io
2023-08-06 13:04           ` Sami Mujawar
2023-07-25 10:31 ` [edk2-devel] [PATCH edk2-platforms v1 3/3] Platform/ARM: FVP: Add ETE device if supported by FVP Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27848.1691045321153861434@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox