From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CC0F1D81120 for ; Thu, 3 Aug 2023 07:00:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KoeMwf9CC2KbaxBj1LoE9JyEGXzIyRBMM4Of+cLKnTY=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691046038; v=1; b=v/1O6qnXZeaNlorbWVUbnoibQtOyEVxT9jrLOwxqnzUj9vEEX3kTB2FRe8nY/ScZdXr8bF2c e2f9xlbM6qPPrFKPIkFCaYmrdD+R7heD+GfSAbtcB3fyRLJTgbD2Os6cuKTM5YBFYAhL/6Yrf3d DhwMKdjN9dQMtQtSkPKjrNSw= X-Received: by 127.0.0.2 with SMTP id f8AhYY7687511xsdmdYPznJK; Thu, 03 Aug 2023 00:00:38 -0700 Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC To: Jeshua Smith ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Bengaluru, Karnataka, IN (223.233.87.165) X-Originating-Platform: Mac Firefox 115 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 03 Aug 2023 00:00:38 -0700 References: In-Reply-To: Message-ID: <27848.1691046038080870810@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vtXFJPbDJZHCHBYmU5fG5ANUx7686176AA= Content-Type: multipart/alternative; boundary="Qd4wZLRpieygGKlz6IqW" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="v/1O6qnX"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) --Qd4wZLRpieygGKlz6IqW Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jeshua, On Wed, Aug 2, 2023 at 02:48 PM, Jeshua Smith wrote: >=20 > This code depends on ArmReadIdAA64Dfr0(), which as far as I can tell is > not present in the EDK2 repo or the patch series mentioned in your 0/3 > message. > toggle quoted message Show quoted text ( #quoted-225764875 ) Apparently the ArmReadIdAA64Dfr0() was added 4 months ago and is already pr= esent in ArmLib in upstream edk2, see https://github.com/tianocore/edk2/bla= me/master/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S#L478-L480 and this= is also present in my edk2 ETE patch series at https://github.com/samimuja= war/edk2/blame/2620_ete_dev_fvp_v1/ArmPkg/Library/ArmLib/AArch64/AArch64Sup= port.S#L478-L480 can you check, please? Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107522): https://edk2.groups.io/g/devel/message/107522 Mute This Topic: https://groups.io/mt/100347409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --Qd4wZLRpieygGKlz6IqW Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jeshua,
On Wed, Aug 2, 2023 at 02:48 PM, Jeshua Smith wrote:
Thi= s code depends on ArmReadIdAA64Dfr0(), which as far as I can tell is not pr= esent in the EDK2 repo or the patch series mentioned in your 0/3 message. toggle quo= ted message Show quoted text 

Apparently the ArmReadIdAA64Dfr0() was added 4 months ago and is alre= ady present in ArmLib in upstream edk2, see https://github.com/tianocore/e= dk2/blame/master/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S#L478-L480 and this is also present in my edk2 ETE patch series at = https://github.com/samimujawar/edk2/blame/2620_ete_dev_fvp_v1/ArmPkg/Librar= y/ArmLib/AArch64/AArch64Support.S#L478-L480 can you check, please?

Regards,

Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#107522) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--Qd4wZLRpieygGKlz6IqW--