Re: [Patch 1/5] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47

[Laszlo Ersek <lersek@redhat.com>]

Hi Liming,

On 12/24/18 16:01, Liming Gao wrote:
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> This drops ARM and AARCH64 support from the GCC46 and GCC47 toolchain
> definitions, which are on the list to be removed, along with VS2003,
> VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, ELFGCC, CYGGCC,
> ICC, ICC11 and MYTOOLS.
> 
> Since GCC46 and GCC47 are the only ones on that list that support ARM
> and/or AARCH64, let's give Liming a hand and cover the ARM side of
> things first, so that everything that remains to be removed is x86
> only.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  BaseTools/Conf/tools_def.template | 143 ++++----------------------------------
>  1 file changed, 14 insertions(+), 129 deletions(-)
> 

(1) I think you need to append at least your S-o-b, at the bottom of the
commit message.

(2) If this patch is 100% identical to
<http://mid.mail-archive.com/20181208093242.3313-1-ard.biesheuvel@linaro.org>,
then please pick up all the review tags given in that thread (from Leif,
yourself, and me).

The idea is that you are forwarding / including this patch from Ard, so
I believe the final list of tags should be:

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Liming Gao <liming.gao@intel.com>

Thanks
Laszlo