From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8F7E21191739 for ; Sun, 30 Dec 2018 16:34:06 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 315ACA459D; Mon, 31 Dec 2018 00:34:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-193.rdu2.redhat.com [10.10.120.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9428560851; Mon, 31 Dec 2018 00:34:04 +0000 (UTC) To: Liming Gao References: <20181224150107.28624-1-liming.gao@intel.com> <20181224150107.28624-2-liming.gao@intel.com> Cc: edk2-devel@lists.01.org, Ard Biesheuvel , "Leif Lindholm (Linaro address)" From: Laszlo Ersek Message-ID: <278b984f-a209-98ac-0653-41eea138a37d@redhat.com> Date: Mon, 31 Dec 2018 01:34:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181224150107.28624-2-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 31 Dec 2018 00:34:06 +0000 (UTC) Subject: Re: [Patch 1/5] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2018 00:34:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Liming, On 12/24/18 16:01, Liming Gao wrote: > From: Ard Biesheuvel > > This drops ARM and AARCH64 support from the GCC46 and GCC47 toolchain > definitions, which are on the list to be removed, along with VS2003, > VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, ELFGCC, CYGGCC, > ICC, ICC11 and MYTOOLS. > > Since GCC46 and GCC47 are the only ones on that list that support ARM > and/or AARCH64, let's give Liming a hand and cover the ARM side of > things first, so that everything that remains to be removed is x86 > only. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 143 ++++---------------------------------- > 1 file changed, 14 insertions(+), 129 deletions(-) > (1) I think you need to append at least your S-o-b, at the bottom of the commit message. (2) If this patch is 100% identical to , then please pick up all the review tags given in that thread (from Leif, yourself, and me). The idea is that you are forwarding / including this patch from Ard, so I believe the final list of tags should be: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Liming Gao Thanks Laszlo