public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "King Sumo" <kingsumos@gmail.com>
To: Andrew Fish <afish@apple.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] UefiPayloadPkg: assert error in PciHostBridgeDxe
Date: Mon, 06 Jul 2020 12:58:07 -0700	[thread overview]
Message-ID: <27945.1594065487881381394@groups.io> (raw)
In-Reply-To: <8D20B013-24B7-4447-8B9D-469016992898@apple.com>

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

On Fri, Jul 3, 2020 at 11:30 AM, Andrew Fish wrote:

> 
> At the same time, the platform's PciHostBridgeLib instance reported a
> root bridge with an MMIO aperture at [D4000000, FE100000), with
> capabilities 1.
> 
> This is a conflict. The capabilities don't even matter (we don't even
> check whether the existent GCD descriptor's capabilities are a superset
> of the aperture's), because the aperture requires GCD memory type
> EfiGcdMemoryTypeMemoryMappedIo, but the GCD descriptor has type
> EfiGcdMemoryTypeReserved.
> 
> In brief, the failure is due to the platform reporting a PCI root bridge
> aperture such that it overlaps an area that is already listed as
> "reserved" in the GCD memory space map. So this is a platform bug;
> either in the "PciHostBridgeLib" instance, or in the module that
> populates the GCD memory space map.

Thanks Andrew and Laszlo!

The map (E0000000, F0000000) is the PCIE Base Address, maybe BlSupportPeim of UefiPayloadPkg have added this in the GCD - I'm not sure if this is correct / normal. Looks like BlSupportPeim is adding to GCD several memory regions during the initialization.
Anyway, the PCIe root bridge MMIO aperture (D4000000, FE100000) looks pretty weird, I'll double check if coreboot is configuring the root port correctly.

Thanks,
Sumo

[-- Attachment #2: Type: text/html, Size: 3316 bytes --]

  reply	other threads:[~2020-07-06 19:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 22:54 UefiPayloadPkg: assert error in PciHostBridgeDxe King Sumo
2020-07-02 23:03 ` [edk2-devel] " Andrew Fish
2020-07-03 18:06   ` Laszlo Ersek
2020-07-03 18:29     ` Andrew Fish
2020-07-06 19:58       ` King Sumo [this message]
2021-05-12 10:43         ` King Sumo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27945.1594065487881381394@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox