From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.74.1588265235441706589 for ; Thu, 30 Apr 2020 09:47:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OYe0+APT; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588265234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQhLZedwJwCyNC8V8rW9YXI99t5+QV6w4q/DWnoZIpA=; b=OYe0+APTf/Jg/69SyLuexV01BAbhSwe47AjRTvatCTGuwIgqwmaC9O2AeMRX5itWovpKdi EupDtvONUIR9LTbt/IV12ZxQFhTE7xBjgaLaIfl8idQlsCWmu/EnuuWvegY5i1BFkB7P/D 5HxbYSKck/lt5mrkRx+r96ioA4PgBgY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-UmqbXnNlOt6-41PE4TaDzg-1; Thu, 30 Apr 2020 12:46:59 -0400 X-MC-Unique: UmqbXnNlOt6-41PE4TaDzg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9301F1005510; Thu, 30 Apr 2020 16:46:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-57.ams2.redhat.com [10.36.115.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 393AE100164D; Thu, 30 Apr 2020 16:46:57 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Add QemuFwCfgLibNull To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200430132202.627023-1-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: <279fcfc7-228f-ec56-14db-91c53c466694@redhat.com> Date: Thu, 30 Apr 2020 18:46:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200430132202.627023-1-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/30/20 15:22, Rebecca Cran wrote: > Add a null implementation library for QemuFwCfgLib, in order to > support building PciHostBridgeLib for bhyve. > > Signed-off-by: Rebecca Cran > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > --- > .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 ++++ > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++++++++++++++++++ > 2 files changed, 246 insertions(+) > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c (a) For the record, the "bhyve v3" instance of this patch [0] and the "bhyve v4" instance of this patch [1] are identical. (b) This stand-alone patch differs from both the "bhyve v3" instance [0] and the (identical) "bhyve v4" instance [1] as follows: > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c > index af29471c1f27..2a8f1316ba6c 100644 > --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c > @@ -11,7 +11,7 @@ > > #include > #include > -#include > +#include > > /** > Returns a boolean indicating if the firmware configuration interface which is what Phil asked for in [2]. So that's good. (c) However, you didn't address my "bhyve v3" comments at all, which I posted at [3]. (The #include directive that you updated at Phil's request only happens to solve part of my point (8).) Please pay more attention to review feedback. If you post a new version without even attempting to address review comments, that's a waste of time for both you and your reviewers. (d) Please get your git setup in functional order *consistently*. This patch only adds new files (doesn't modify existing files), so there is no conflict due to on context lines or removed lines. But both new files have after the patch is applied with git-am. Thanks Laszlo [0] http://mid.mail-archive.com/20200421030955.114850-3-rebecca@bsdio.com https://edk2.groups.io/g/devel/message/57692 [1] http://mid.mail-archive.com/20200424182914.138915-3-rebecca@bsdio.com https://edk2.groups.io/g/devel/message/58098 [2] http://mid.mail-archive.com/5934622c-7235-d073-cdf4-957d6b684c67@redhat.com https://edk2.groups.io/g/devel/message/58230 [3] http://mid.mail-archive.com/b3bd046e-1762-243f-e1c6-01660ad6a8d4@redhat.com https://edk2.groups.io/g/devel/message/57913