From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.70]) by mx.groups.io with SMTP id smtpd.web08.8335.1647510876978684882 for ; Thu, 17 Mar 2022 02:54:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=w+fuA6+G; spf=pass (domain: arm.com, ip: 40.107.15.70, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6AvdfggAqxQ8DOXrg+qmxiq4jzt2NG8hJhkx0zv/iA=; b=w+fuA6+GHkr8NCJOoxyxFM6MB7B3CvwZ4cHlFCRXKycImUWaWWevvgsRM22EpnMxwy1Lb4RYPkLGqQj2K5S8gGjvVOEN8hYxCKTsMIVbyi/q6RbHrdIvO7m4IEYjPoqDmg6XhubtTiPpl2tH6/zJvYhkvgcJ3UhFMqSedTvLJK0= Received: from AS9PR06CA0019.eurprd06.prod.outlook.com (2603:10a6:20b:462::12) by PAXPR08MB6956.eurprd08.prod.outlook.com (2603:10a6:102:1db::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Thu, 17 Mar 2022 09:54:34 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:462:cafe::1e) by AS9PR06CA0019.outlook.office365.com (2603:10a6:20b:462::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.24 via Frontend Transport; Thu, 17 Mar 2022 09:54:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14 via Frontend Transport; Thu, 17 Mar 2022 09:54:33 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Thu, 17 Mar 2022 09:54:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 804d1fabb0bd2073 X-CR-MTA-TID: 64aa7808 Received: from 3cd91b8020da.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EDF562EE-113E-4845-8EBF-A4C0FC54DB5D.1; Thu, 17 Mar 2022 09:54:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3cd91b8020da.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Mar 2022 09:54:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxppsREl1R9lOru7OBIyuyuyayd85VykJVLJyD9Ac/y9V2wf0/2q/diLKEA+QxbHelWiJxhZY00D5UyBLe8o/yVJoPHP3ao4lkgdr2qH6LcOHxb9CWctpmqkNNNyOcgewk3K6BPRTkBXxsotJqyTsfTIUx6yRyKprXOr3BLnBxz0FTRpbHwneJTBixEF4CX0bCvzBrrrIblzFzT9P4dU/dVVuVIb//IKvm0gW+s2ZVgqKgitP1GdBGqbsd7nXBqxm8mzPN0WBK7DBK2Cm71glbvFpsOm5VsU4mm070ZGnY5ksiz29qb8g1L8hVTRdadAqMwxvFmzb80SXBCxLiEEwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X6AvdfggAqxQ8DOXrg+qmxiq4jzt2NG8hJhkx0zv/iA=; b=FYfdFCnzFGjfZ6zfXER3lMuVNTzLynhbBEzgbhdhV/ljfL72kNt1+pz4dtn7D9n7Qc5VrBtMgMwi/dATBA1rOH6FV7qhs0APUAOi7ATbElyLMU0+JyUI+MXFg7R1J/wrfOvtl349YrjkhdCRpee0iAxN2BqEtcjlVhEX++J6ZZt9AZhwmkYIbKf9aEjDxUXMHxMkEr8Z4O/ft2Epqh2OU2wdH5llt944kvHp4nfrJFExwAIuDync1mIuOVZvYBHeLuX1ZA4aHs7OeqLrnXa3IgHRpdW8DSyekt+GSj612yhcQSPIyFyAL+kyqap5Smu2JcQHGLnqtngHDVvoKk7pnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6AvdfggAqxQ8DOXrg+qmxiq4jzt2NG8hJhkx0zv/iA=; b=w+fuA6+GHkr8NCJOoxyxFM6MB7B3CvwZ4cHlFCRXKycImUWaWWevvgsRM22EpnMxwy1Lb4RYPkLGqQj2K5S8gGjvVOEN8hYxCKTsMIVbyi/q6RbHrdIvO7m4IEYjPoqDmg6XhubtTiPpl2tH6/zJvYhkvgcJ3UhFMqSedTvLJK0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB8PR08MB5052.eurprd08.prod.outlook.com (2603:10a6:10:e8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Thu, 17 Mar 2022 09:54:18 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1dca:9b48:ed8e:b682]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1dca:9b48:ed8e:b682%6]) with mapi id 15.20.5081.017; Thu, 17 Mar 2022 09:54:18 +0000 Subject: Re: [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM addr To: Rebecca Cran , devel@edk2.groups.io, Ard Biesheuvel , Thomas Abraham , nd References: <20220305041955.20918-1-rebecca@bsdio.com> <20220305041955.20918-3-rebecca@bsdio.com> From: "Sami Mujawar" Message-ID: <27a3e61f-c708-5710-f4d7-7475d73b0e20@arm.com> Date: Thu, 17 Mar 2022 09:54:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20220305041955.20918-3-rebecca@bsdio.com> X-ClientProxiedBy: LO2P265CA0359.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::35) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fdb01ce1-f834-44c6-0ee7-08da07fc237c X-MS-TrafficTypeDiagnostic: DB8PR08MB5052:EE_|VE1EUR03FT022:EE_|PAXPR08MB6956:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gRuM3nMbbv8xpji+3vVSioeAvMxuNMLkpvdyzzaSlsGXBuMx6bRb+leD0Fc1g/skX63vyL63iNOTNDtocIiGGIwfFYbF39G97Qu8i6g6fkHwKBXCrEBOSol/uzdk/Oc6z0RTF6Fp3zwQ51lG3RIMunVbNiYDelEJFocG2S2s/MW2EqldJIU3x0g/D8hl1FP97GEeC5F9Dw02mufLCyu8kBJQOPcGZ1TXAvRtTUfYU4nCKrYim+CAGeuYiCNfJFBrhZaNbK9xpTcZpR3MYBo3iMYGoaNsI6zinTnERR3RIeiJTJKzE4+V6aElvHS1Sen8GxL9VVinOayY/yaPrrvKmo7ODdY5L2Gjc0VhbbV3Gmb7sh+/ynZgxk5ZeGkSJkv93A3rXzCKrY62uok0qHjfl/TwOg0iyu9aaK2pPydH3349WiZRZuqHj6NniZbCDV+aebTVeEEN7JFv+Ot+sihHlV/F23KntnQhZMWURKYGhvfcP0+FbL6D0youh8d7sWb2cPBQST+EZX3RKLrgKnxkNE1zIjInGvKYTaRjjv2ljF4Ysh8Ox3a2qAdQCBnr13VARmVQviKr2BapmrCiof/+zVwT/KZWgx2BEFr/2BE4q+zv+IAqbm+hhbngo+ClM6dyMbM3r9wfjZV16xnFfGvrk3LKpiTclBL+Tm0UGYvYo5JyS7NViW54m+hYsTl/mNrQIV0KaPPPGul9ehm1fUjYOr0NsWo49O/x4vpdukNn/yzEQbRuxaKM631QYjkCx7ZKlvUk9SDCtIOqL52UI+dE0WhmYT8qbAafOBFRMyT+RR0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(8936002)(2906002)(31696002)(52116002)(53546011)(44832011)(6486002)(5660300002)(86362001)(508600001)(6506007)(6636002)(110136005)(186003)(31686004)(26005)(8676002)(66476007)(66556008)(66946007)(38100700002)(38350700002)(83380400001)(36756003)(316002)(2616005)(213903007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5052 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 09673610-3165-4d63-5c19-08da07fc1a37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sXueLzbKfcTGAEZMCmyWbDS1J+rpN4JKd8AEcYKnbJnOTM8QCqLaDBTxMV1Z51+6Qa1jc1SsaDmR96YB6du5uY+3Xa6+HYPdjPBRjSHwIzfI8paxbMZ+Qs6zjer8lC3DF97smDcs1OoiaHQbtOMheynIAVckw9nPGcrxzLVASYUG/6igLRpb5hKwy6/ILgLZ1VMc5pX6N4o9K1zeaXTzLH5/E58okZLbYfYq/K3jUtJHu8hpEwHePoELkQirWAEAbfTic6hHUZ7tjTTmGvwb/kGydQFRpTbxrgNSEwh+suDax15T0GKGOjjmFfQasadLJ8oagGeD1BgRf3sM762wFTzNq62zB9fdBV0JcecE8NurB86gY96fc/sW1PSiGM6tzsceMh+F+gC1G2cmwmVph7A5m/iMk9cHUbZLsXbfZqHlBDvjibg3jcIUpSSM8KJuJaZdKguvPEG0KD7ENLDzSvpBSFc09H3kyeje0kXyJQUVYhX5ORgQri7O5xh9GQNgjYcgl8ugeLtvjJymwA6MiJrHQHq7vWB6kctgF/z+Ck/HHufgU7blIXhbeRndzSGrnHdoJE7uFNfU5Li9+mqV45UOg2CYJImyNJ0zwSTJm+5vyk9SjXl6+oAzfsVtmFxlqWH9hs9iPAYjCtxt3okBLmjn5b8/erkSvCKc3bWp8U8JJuTqDIqhf7Gijn6uKcDvx54d06MGCBvTDAjdup6cWT/m05IjAZ6CouoQbytEEVLEFgk+WBIt0/RuLTTkpdV4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6512007)(8936002)(2906002)(31696002)(53546011)(82310400004)(6486002)(44832011)(5660300002)(86362001)(508600001)(40460700003)(6506007)(6636002)(110136005)(336012)(81166007)(8676002)(47076005)(186003)(31686004)(26005)(70206006)(70586007)(356005)(83380400001)(36756003)(316002)(36860700001)(2616005)(213903007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 09:54:33.3426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdb01ce1-f834-44c6-0ee7-08da07fc237c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6956 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Rebecca, I have one minor suggestion marked inline as [SAMI]. Otherwise these changes look good to me. With that changed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/03/2022 04:19 AM, Rebecca Cran wrote: > Instead of using a custom Pcd for the ECAM address > (gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress), > use the Pcd from MdePkg. > > Signed-off-by: Rebecca Cran > --- > Platform/ARM/JunoPkg/ArmJuno.dec = | 4 ++-- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManagerDxe.inf | 2 +- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf = | 2 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf = | 2 +- > Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.= inf | 2 +- > Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.h = | 2 +- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManager.c | 2 +- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c = | 2 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c = | 4 ++-- > 9 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dec b/Platform/ARM/JunoPkg/ArmJ= uno.dec > index 37ea6857366f..b6437d6fe98c 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dec > +++ b/Platform/ARM/JunoPkg/ArmJuno.dec > @@ -34,8 +34,8 @@ [PcdsFeatureFlag.common] > [PcdsFixedAtBuild.common] > gArmJunoTokenSpaceGuid.PcdPcieControlBaseAddress|0x7FF20000|UINT64|0x= 0000000B > gArmJunoTokenSpaceGuid.PcdPcieRootPortBaseAddress|0x7FF30000|UINT64|0= x0000000C > - gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress|0x40000000|= UINT64|0x00000011 > - gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize|0x10000000|UINT64|= 0x00000012 > + gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize|0x10000000|UINT64|= 0x00000011 > + gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceLimit|0x4FFFFFFF|UINT64= |0x00000012 > > gArmJunoTokenSpaceGuid.PcdSynopsysUsbOhciBaseAddress|0x7FFB0000|UINT3= 2|0x00000004 > gArmJunoTokenSpaceGuid.PcdSynopsysUsbEhciBaseAddress|0x7FFC0000|UINT3= 2|0x00000005 > diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManag= erDxe/ConfigurationManagerDxe.inf b/Platform/ARM/JunoPkg/ConfigurationManag= er/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > index 00be2c435bd6..7ca134d6674b 100644 > --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManagerDxe.inf > +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManagerDxe.inf > @@ -46,7 +46,7 @@ [Protocols] > > [FixedPcd] > # PCI Root complex specific PCDs > - gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize > > ## PL011 Serial Debug UART > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/Pla= tform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf > index d016967c3c37..c35984c172e1 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf > @@ -67,7 +67,7 @@ [FixedPcd] > gArmJunoTokenSpaceGuid.PcdJunoFdtDevicePath > > # PCI Root complex specific PCDs > - gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > gArmTokenSpaceGuid.PcdPciBusMin > gArmTokenSpaceGuid.PcdPciBusMax > > diff --git a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf b/Pla= tform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf > index 145663c2fa28..fb80f10a9409 100644 > --- a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf > +++ b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf > @@ -45,7 +45,7 @@ [FixedPcd] > gArmTokenSpaceGuid.PcdArmPrimaryCoreMask > > gArmJunoTokenSpaceGuid.PcdPcieControlBaseAddress > - gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize > > # Framebuffer Memory > diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHos= tBridgeLib.inf b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciH= ostBridgeLib.inf > index f448803fda7d..784618ffa013 100644 > --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridge= Lib.inf > +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridge= Lib.inf > @@ -62,7 +62,7 @@ [FixedPcd] > > gArmJunoTokenSpaceGuid.PcdPcieControlBaseAddress > gArmJunoTokenSpaceGuid.PcdPcieRootPortBaseAddress > - gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize > > [Protocols] > diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich= 3.h b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.h > index 420bdda7534b..78889c1b1196 100644 > --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.h > +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.h > @@ -13,7 +13,7 @@ > #include > #include > > -#define PCI_ECAM_BASE FixedPcdGet64 (PcdPciConfigurationSpaceBaseA= ddress) > +#define PCI_ECAM_BASE FixedPcdGet64 (PcdPciExpressBaseAddress) > #define PCI_ECAM_SIZE FixedPcdGet64 (PcdPciConfigurationSpaceSize= ) > #define PCI_IO_BASE FixedPcdGet64 (PcdPciIoTranslation) > #define PCI_IO_SIZE FixedPcdGet64 (PcdPciIoSize) > diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManag= erDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/Co= nfigurationManagerDxe/ConfigurationManager.c > index 80a98a10d869..3420b6eba66a 100644 > --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManager.c > +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManager.c > @@ -230,7 +230,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformReposit= oryInfo =3D { > // PCI Configuration Space Info > { > // The physical base address for the PCI segment > - FixedPcdGet64 (PcdPciConfigurationSpaceBaseAddress), > + FixedPcdGet64 (gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress), [SAMI] I think this should just be FixedPcdGet64 (PcdPciExpressBaseAddress). > // The PCI segment group number > 0, > // The start bus number > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c b/Platf= orm/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c > index aaa493a9284b..870dfa5f7ef3 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c > @@ -30,7 +30,7 @@ MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ACCESS_TABLE mAc= piMcfgTable =3D { > ), > 0, // Reserved > }, { > - FixedPcdGet32 (PcdPciConfigurationSpaceBaseAddress), > + FixedPcdGet32 (PcdPciExpressBaseAddress), > 0, // PciSegmentGroupNumber > FixedPcdGet32 (PcdPciBusMin), > FixedPcdGet32 (PcdPciBusMax), > diff --git a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c b/Platf= orm/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c > index 990a1664e496..8ac2e3273a4a 100644 > --- a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c > +++ b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c > @@ -118,8 +118,8 @@ ArmPlatformGetVirtualMemoryMap ( > // > // PCI Configuration Space > // > - VirtualMemoryTable[++Index].PhysicalBase =3D PcdGet64 (PcdPciConfigur= ationSpaceBaseAddress); > - VirtualMemoryTable[Index].VirtualBase =3D PcdGet64 (PcdPciConfigur= ationSpaceBaseAddress); > + VirtualMemoryTable[++Index].PhysicalBase =3D PcdGet64 (PcdPciExpressB= aseAddress); > + VirtualMemoryTable[Index].VirtualBase =3D PcdGet64 (PcdPciExpressB= aseAddress); > VirtualMemoryTable[Index].Length =3D PcdGet64 (PcdPciConfigu= rationSpaceSize); > VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRI= BUTE_DEVICE; > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.