From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web11.19023.1594915921551562132
 for <devel@edk2.groups.io>;
 Thu, 16 Jul 2020 09:12:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CAGsHHBO;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1594915920;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=e77sAVaXmEn3Pw8bSfSHEIzn1szSAi8khubrRwhDX0o=;
	b=CAGsHHBOz2t6j8Bix72RJkB4XnFp9r+yJBvYUuEiT9DBY9jhUJqCNTbk3TY8uFjIN7oKds
	PK0j09gmy+kpSxDbctDHfGMy9pqNTIOOC/HIX/b/mvWb+ThPQZzQ/ntkRYQrw1Pq7p+qfF
	+4w5hdA7GN7pOhQ+qjs9rxPcccK4d1c=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-358-XiUJiPGYONy-1vhCXL_uSA-1; Thu, 16 Jul 2020 12:11:56 -0400
X-MC-Unique: XiUJiPGYONy-1vhCXL_uSA-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB4ED10059B2;
	Thu, 16 Jul 2020 16:11:55 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-123.ams2.redhat.com [10.36.112.123])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 452DC10013D7;
	Thu, 16 Jul 2020 16:11:54 +0000 (UTC)
Subject: Re: [PATCH v2 08/12] OvmfPkg/LsiScsiDxe: Map DMA buffer
To: Gary Lin <glin@suse.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20200716074607.18048-1-glin@suse.com>
 <20200716074607.18048-9-glin@suse.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <27ac471d-6b9a-3834-105b-1d4cb64e4bac@redhat.com>
Date: Thu, 16 Jul 2020 18:11:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200716074607.18048-9-glin@suse.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07/16/20 09:46, Gary Lin wrote:
> Map DMA buffer and perpare for the implementation of LsiScsiPassThru().
> 
> v2:
>   - Replace 0x10000 with SIZE_64KB macro for the DMA buffer data array
>   - Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need
>     64-bit DMA address
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/LsiScsiDxe/LsiScsi.c | 62 +++++++++++++++++++++++++++++++++++-
>  OvmfPkg/LsiScsiDxe/LsiScsi.h | 14 ++++++++
>  2 files changed, 75 insertions(+), 1 deletion(-)

looks good, thanks