From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()
Date: Thu, 2 Apr 2020 14:44:13 +0200 [thread overview]
Message-ID: <27b805a6-4bc6-84bd-13d7-c0f2a24aee66@arm.com> (raw)
In-Reply-To: <20200402110316.GP7468@vanye>
On 4/2/20 1:03 PM, Leif Lindholm wrote:
> On Thu, Apr 02, 2020 at 12:29:30 +0200, Ard Biesheuvel wrote:
>> On 4/2/20 12:28 PM, Leif Lindholm wrote:
>>> On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote:
>>>> On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote:
>>>>> On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote:
>>>>>> Before getting rid of GetRootTranslationTableInfo() and the related
>>>>>> LookupAddresstoRootTable() in AARCH64's version of ArmMmuLib, add a
>>>>>> version of the former to CpuDxe, which will be its only remaining
>>>>>> user. While at it, simplify it a bit, since in the CpuDxe cases,
>>>>>> both OUT arguments are always provided.
>
> Summary after discussing off-list:
> This patch isn't *just* moving a public function private, but it's
> replacing use of a function that was never meant to be public and had
> a completely bonkers forward-declaration in a different module.
>
> Ard has agreed to make the commit message more explicit on that point,
> and I'm happy with that. So with that change, for the series:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
Pushed, thanks.
next prev parent reply other threads:[~2020-04-02 12:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 10:43 [PATCH 0/5] ArmPkg: cosmetic cleanups for ArmMmuLib Ard Biesheuvel
2020-03-28 10:43 ` [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo() Ard Biesheuvel
2020-04-02 10:16 ` Leif Lindholm
2020-04-02 10:20 ` [edk2-devel] " Ard Biesheuvel
2020-04-02 10:28 ` Leif Lindholm
2020-04-02 10:29 ` Ard Biesheuvel
2020-04-02 11:03 ` Leif Lindholm
2020-04-02 12:44 ` Ard Biesheuvel [this message]
2020-03-28 10:43 ` [PATCH 2/5] ArmPkg/CpuDxe: move PageAttributeToGcdAttribute() out of ArmMmuLib Ard Biesheuvel
2020-03-28 10:43 ` [PATCH 3/5] ArmPkg/ArmMmuLib: drop pointless LookupAddresstoRootTable() routine Ard Biesheuvel
2020-03-28 10:43 ` [PATCH 4/5] ArmPkg/ArmMmuLib: get rid of GetRootTranslationTableInfo() Ard Biesheuvel
2020-03-28 10:43 ` [PATCH 5/5] ArmPkg/ArmMmuLib: drop unused TT_ATTR_INDX_INVALID CPP symbol Ard Biesheuvel
2020-04-02 10:23 ` Leif Lindholm
2020-04-02 10:29 ` [edk2-devel] " Ard Biesheuvel
2020-04-02 10:57 ` Leif Lindholm
2020-04-02 11:05 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27b805a6-4bc6-84bd-13d7-c0f2a24aee66@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox