From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.5711.1585831456782377303 for ; Thu, 02 Apr 2020 05:44:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5FC7C30E; Thu, 2 Apr 2020 05:44:16 -0700 (PDT) Received: from [10.37.8.12] (unknown [10.37.8.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F8E03F68F; Thu, 2 Apr 2020 05:44:15 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo() To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel References: <20200328104321.8668-1-ard.biesheuvel@linaro.org> <20200328104321.8668-2-ard.biesheuvel@linaro.org> <20200402101610.GL7468@vanye> <20200402102804.GN7468@vanye> <0e6a6c40-1a48-a5cb-563f-4f5b39c41fef@arm.com> <20200402110316.GP7468@vanye> From: "Ard Biesheuvel" Message-ID: <27b805a6-4bc6-84bd-13d7-c0f2a24aee66@arm.com> Date: Thu, 2 Apr 2020 14:44:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200402110316.GP7468@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/2/20 1:03 PM, Leif Lindholm wrote: > On Thu, Apr 02, 2020 at 12:29:30 +0200, Ard Biesheuvel wrote: >> On 4/2/20 12:28 PM, Leif Lindholm wrote: >>> On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote: >>>> On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote: >>>>> On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote: >>>>>> Before getting rid of GetRootTranslationTableInfo() and the related >>>>>> LookupAddresstoRootTable() in AARCH64's version of ArmMmuLib, add a >>>>>> version of the former to CpuDxe, which will be its only remaining >>>>>> user. While at it, simplify it a bit, since in the CpuDxe cases, >>>>>> both OUT arguments are always provided. > > Summary after discussing off-list: > This patch isn't *just* moving a public function private, but it's > replacing use of a function that was never meant to be public and had > a completely bonkers forward-declaration in a different module. > > Ard has agreed to make the commit message more explicit on that point, > and I'm happy with that. So with that change, for the series: > Reviewed-by: Leif Lindholm > Pushed, thanks.