From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0DDD7D8067E for ; Tue, 20 Feb 2024 16:48:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hBdTQTQA6npgVz1TmUGn3i5juRY7tSKjUGRh+4PmsWU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708447729; v=1; b=mEVbk3jc4fAtblFpk2Kch/QekjzZDslmljWLzo3zeDW1eIYhIeaYkzUP5gF80iJLgvf/NVmN E3X9TQLwbiIBanOjzwhuymSZ1eOko2JGVcWrfjOaMlrQFvgAJLRaH3hwGeDco1x/nq9z7gq1WPm lmhCJwBVeXMO635DdpdanO7E= X-Received: by 127.0.0.2 with SMTP id 6XXXYY7687511xEkcWx1KtDw; Tue, 20 Feb 2024 08:48:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.17932.1708447729127099283 for ; Tue, 20 Feb 2024 08:48:49 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-yC49qq8xPQSCuEudrpM4Jw-1; Tue, 20 Feb 2024 11:48:43 -0500 X-MC-Unique: yC49qq8xPQSCuEudrpM4Jw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E67688CDD3; Tue, 20 Feb 2024 16:48:42 +0000 (UTC) X-Received: from [10.39.192.75] (unknown [10.39.192.75]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A7D92166AF1; Tue, 20 Feb 2024 16:48:40 +0000 (UTC) Message-ID: <27cbae99-3790-b0e8-7940-3cf1cb38e7db@redhat.com> Date: Tue, 20 Feb 2024 17:48:38 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 4/6] OvmfPkg/ResetVector: SEV: keep #vc handler installed longer To: devel@edk2.groups.io, kraxel@redhat.com Cc: Liming Gao , Michael Roth , Oliver Steffen , Erdem Aktas , Tom Lendacky , Min Xu , Ard Biesheuvel , Jiewen Yao References: <20240220090639.472222-1-kraxel@redhat.com> <20240220090639.472222-5-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240220090639.472222-5-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: anzoC7ZHNgH5c9G1gxesQIYbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mEVbk3jc; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/20/24 10:06, Gerd Hoffmann wrote: > When running in SEV mode do not uninstall the #vc handler in > CheckSevFeatures. Keep it active and uninstall it later in > SevClearPageEncMaskForGhcbPage. >=20 > This allows using the cpuid instruction in SetCr3ForPageTables64, > which is needed to check for la57 & 1G page support. >=20 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) I'll let Tom review this :) Acked-by: Laszlo Ersek >=20 > diff --git a/OvmfPkg/ResetVector/Ia32/AmdSev.asm b/OvmfPkg/ResetVector/Ia= 32/AmdSev.asm > index 043c88a7abbe..02f287f1d934 100644 > --- a/OvmfPkg/ResetVector/Ia32/AmdSev.asm > +++ b/OvmfPkg/ResetVector/Ia32/AmdSev.asm > @@ -158,6 +158,11 @@ SevClearPageEncMaskForGhcbPage: > cmp byte[WORK_AREA_GUEST_TYPE], 1 > jnz SevClearPageEncMaskForGhcbPageExit > =20 > + ; Clear exception handlers and stack > + mov eax, ADDR_OF(IdtrClear) > + lidt [cs:eax] > + mov esp, 0 > + > ; Check if SEV-ES is enabled > mov ecx, 1 > bt [SEV_ES_WORK_AREA_STATUS_MSR], ecx > @@ -332,7 +337,6 @@ NoSevEsVcHlt: > NoSevPass: > xor eax, eax > =20 > -SevExit: > ; > ; Clear exception handlers and stack > ; > @@ -342,6 +346,7 @@ SevExit: > pop eax > mov esp, 0 > =20 > +SevExit: > OneTimeCallRet CheckSevFeatures > =20 > ; Start of #VC exception handling routines -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115662): https://edk2.groups.io/g/devel/message/115662 Mute This Topic: https://groups.io/mt/104464311/7686176 Mute #vc:https://edk2.groups.io/g/devel/mutehashtag/vc Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-