public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	devel@edk2.groups.io, "Jordan Justen" <jordan.l.justen@intel.com>,
	"Laszlo Ersek" <lersek@redhat.com>,
	"Ard Biesheuvel" <ard.biesheuvel@arm.com>,
	"Andrew Fish" <afish@apple.com>,
	"Leif Lindholm" <leif@nuviainc.com>,
	"Michael D Kinney" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull
Date: Tue, 28 Apr 2020 10:12:12 -0600	[thread overview]
Message-ID: <27edd21c-6617-b26e-9735-90ccee8df6fb@bsdio.com> (raw)
In-Reply-To: <5934622c-7235-d073-cdf4-957d6b684c67@redhat.com>

On 4/28/20 5:27 AM, Philippe Mathieu-Daudé wrote:

>
>> I'll fix this if/when I need to send a v5 series out, or since it 
>> doesn't seem to do any harm in a later patch.
>>
>>
>
> OK. Changing <IndustryStandard/QemuFwCfg.h> by <Library/QemuFwCfgLib.h>:
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


Oh, I see my mistake. There's QemuFwCfg.h and QemuFwCfgLib.h and I 
included the wrong one. That _is_ something I'll need to fix before 
committing.

Should I just send out a v5 series now, with that fix?


-- 
Rebecca Cran



  reply	other threads:[~2020-04-28 16:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 18:29 [PATCH v4 0/6] Add BhyvePkg, to support the bhyve hypervisor Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 1/6] OvmfPkg: Add bhyve support into AcpiTimerLib Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull Rebecca Cran
2020-04-27  9:03   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-04-27 17:33     ` Rebecca Cran
2020-04-28 11:27       ` Philippe Mathieu-Daudé
2020-04-28 16:12         ` Rebecca Cran [this message]
2020-04-24 18:29 ` [PATCH v4 3/6] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 4/6] Add BhyvePkg, to support the bhyve hypervisor Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 5/6] BhyvePkg: Add PlatformPei Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 6/6] BhyvePkg: Add AcpiPlatformDxe Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27edd21c-6617-b26e-9735-90ccee8df6fb@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox