From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by mx.groups.io with SMTP id smtpd.web10.379.1588090337059534751 for ; Tue, 28 Apr 2020 09:12:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: bsdio.com, ip: 166.70.13.232, mailfrom: rebecca@bsdio.com) Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTSqF-000310-0f; Tue, 28 Apr 2020 10:12:15 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jTSqE-0001bN-De; Tue, 28 Apr 2020 10:12:14 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 0582D12804A2; Tue, 28 Apr 2020 10:12:14 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7N8zw5xmcbml; Tue, 28 Apr 2020 10:12:13 -0600 (MDT) Received: from [10.0.10.120] (muon.bluestop.org [65.103.231.193]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 897361280118; Tue, 28 Apr 2020 10:12:13 -0600 (MDT) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20200424182914.138915-1-rebecca@bsdio.com> <20200424182914.138915-3-rebecca@bsdio.com> <654ce10b-e878-64df-9778-122d3454cc89@bsdio.com> <5934622c-7235-d073-cdf4-957d6b684c67@redhat.com> From: "Rebecca Cran" Message-ID: <27edd21c-6617-b26e-9735-90ccee8df6fb@bsdio.com> Date: Tue, 28 Apr 2020 10:12:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <5934622c-7235-d073-cdf4-957d6b684c67@redhat.com> X-XM-SPF: eid=1jTSqE-0001bN-De;;;mid=<27edd21c-6617-b26e-9735-90ccee8df6fb@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=pass X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa02.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,TooManyTo_001, TooManyTo_002,TooManyTo_003,TooManyTo_004,TooManyTo_005,XMSubLong, XM_B_Unicode autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5039] * 0.5 TooManyTo_004 Multiple "To" Header Recipients 5x (uncommon) * 0.4 TooManyTo_005 Multiple "To" Header Recipients 6x (uncommon) * 0.6 TooManyTo_003 Multiple "To" Header Recipients 4x (uncommon) * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.5 TooManyTo_002 Multiple "To" Header Recipients 3x (uncommon) * 0.7 XMSubLong Long Subject * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa02 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: =?ISO-8859-1?Q?**;Philippe Mathieu-Daud=c3=a9 , devel@edk2.groups.io, Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Andrew Fish , Leif Lindholm , Michael D Kinney ?= X-Spam-Relay-Country: X-Spam-Timing: total 395 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 3.9 (1.0%), b_tie_ro: 2.7 (0.7%), parse: 0.80 (0.2%), extract_message_metadata: 2.9 (0.7%), get_uri_detail_list: 0.47 (0.1%), tests_pri_-1000: 2.1 (0.5%), tests_pri_-950: 1.02 (0.3%), tests_pri_-900: 0.83 (0.2%), tests_pri_-90: 75 (19.1%), check_bayes: 74 (18.8%), b_tokenize: 4.3 (1.1%), b_tok_get_all: 4.8 (1.2%), b_comp_prob: 1.10 (0.3%), b_tok_touch_all: 61 (15.5%), b_finish: 0.77 (0.2%), tests_pri_0: 299 (75.7%), check_dkim_signature: 0.40 (0.1%), check_dkim_adsp: 186 (47.0%), poll_dns_idle: 180 (45.6%), tests_pri_10: 1.77 (0.4%), tests_pri_500: 6 (1.4%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 4/28/20 5:27 AM, Philippe Mathieu-Daudé wrote: > >> I'll fix this if/when I need to send a v5 series out, or since it >> doesn't seem to do any harm in a later patch. >> >> > > OK. Changing by : > Reviewed-by: Philippe Mathieu-Daude Oh, I see my mistake. There's QemuFwCfg.h and QemuFwCfgLib.h and I included the wrong one. That _is_ something I'll need to fix before committing. Should I just send out a v5 series now, with that fix? -- Rebecca Cran