public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Rebecca Cran <rebecca@bluestop.org>
To: edk2-devel@lists.01.org
Subject: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg
Date: Thu, 16 Feb 2017 15:47:33 -0700	[thread overview]
Message-ID: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org> (raw)

I'm a bit confused about why Firmware Management Protocol image 
descriptor structures are split between MdePkg and ShellPkg:

In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition 
of EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3).  But then the 
EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2 
struct definitions are in 
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h along with 
some seemingly-unrelated stuff - and that file appears to have a 
ridiculous number of #include's!


Is there a reasoning behind putting the older structures in ShellPkg, or 
should they be moved to FirmwareInformation.h?


-- 

Rebecca



             reply	other threads:[~2017-02-16 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 22:47 Rebecca Cran [this message]
2017-02-16 22:58 ` EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg Yao, Jiewen
2017-02-16 22:59 ` Shah, Tapan
2017-02-16 23:12   ` Yao, Jiewen
2017-02-17 15:42     ` Shah, Tapan
2017-02-17 16:03       ` Carsey, Jaben
2017-02-17 16:46         ` Shah, Tapan
2017-02-16 23:16   ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox