From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muon.cran.org.uk (muon.bluestop.org [IPv6:2605:7700:0:8:1:0:4a32:3323]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 99A84820F6 for ; Thu, 16 Feb 2017 14:47:37 -0800 (PST) Received: from muon.bluestop.org (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id 814247B25D for ; Thu, 16 Feb 2017 22:47:35 +0000 (UTC) Received: from muon.cran.org.uk ([127.0.0.1]) by muon.bluestop.org (muon.bluestop.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1E9BGG5YCoLr for ; Thu, 16 Feb 2017 22:47:35 +0000 (UTC) Received: from [192.168.1.19] (c-73-20-20-155.hsd1.ut.comcast.net [73.20.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA for ; Thu, 16 Feb 2017 22:47:35 +0000 (UTC) To: edk2-devel@lists.01.org From: Rebecca Cran Message-ID: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org> Date: Thu, 16 Feb 2017 15:47:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Subject: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 22:47:37 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I'm a bit confused about why Firmware Management Protocol image descriptor structures are split between MdePkg and ShellPkg: In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition of EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3). But then the EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2 struct definitions are in ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h along with some seemingly-unrelated stuff - and that file appears to have a ridiculous number of #include's! Is there a reasoning behind putting the older structures in ShellPkg, or should they be moved to FirmwareInformation.h? -- Rebecca