From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 028CE78003C for ; Wed, 29 May 2024 19:25:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sBXY9bS7kUhTdummgBhFOC+rxvDhqrHuabTdjl58pDU=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717010734; v=1; b=QMueBq9qFn+eOloWQhSngdTwYmzdDbgoJ3GRpaoPi2feVBYhDTMmugiqoDhZn29ifPISwJs4 fmpAmdMQVcFIN/oU35jVb2twApDQt8mkgbQDUnWcdlvNFjmXXSjNvgcUMvIG5Cap+o/JEA976f9 K7PAorTzim1fykLDz+X7l/auQ3qQBg9U/nUlpBJcT0dsr6eFmw2cQQstG1IQqQHTFkB/uNVrqoT 54V345lU4I8tGgdwLeylmx+VunJLWXdho4sZXqrea3XYoJgcCpKttTvWQcerG1IihL95cMZq/hp iJCfpc9pSXj+EZsJG8x2C+gA2wifJMTkWQ7TxptA/EyYQ== X-Received: by 127.0.0.2 with SMTP id ZBbKYY7687511xSvJte4Vt5Q; Wed, 29 May 2024 12:25:33 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.24839.1717010728114778930 for ; Wed, 29 May 2024 12:25:28 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.15]) by linux.microsoft.com (Postfix) with ESMTPSA id 4BAB32067CED; Wed, 29 May 2024 12:25:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4BAB32067CED Message-ID: <28097adb-a5fa-4bc6-ac39-fbf9ff71b9c4@linux.microsoft.com> Date: Wed, 29 May 2024 15:25:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: devel@edk2.groups.io, michael.d.kinney@intel.com, Rebecca Cran , "kraxel@redhat.com" , "Kubacki, Michael" References: <086790e8-a850-426f-86b1-73f54feebc1b@bsdio.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 12:25:28 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DMwjKiG1lbIWqQeAJSga3LASx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=QMueBq9q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Mike, I agree that automatically adding reviewers would be helpful. Do you think we could add a CODEOWNERS file now to assist with this? Benefits being: 1. CODEOWNERS is low overhead in that GitHub already supports it. 2. We do not need to require CODEOWNER enforcement yet. We can simply=20 use it for automating the process of adding maintainers. 3. Maintainers have write access so they are required to approve and add=20 the push label. This would add a relevant maintainer(s) with write=20 access to fulfill that role. Thanks, Michael On 5/29/2024 2:27 PM, Michael D Kinney wrote: > GitHub has notification settings. Maintainers should configure > GitHub so they are notified of all PR submissions to edk2 repo. >=20 > The Wiki for the Maintainer Process provides a link to this page with the= details: >=20 > https://docs.github.com/en/account-and-profile/managing-subscriptions-and= -notifications-on-github/setting-up-notifications/configuring-notifications >=20 > https://docs.github.com/en/account-and-profile/managing-subscriptions-and= -notifications-on-github/setting-up-notifications/configuring-notifications= #about-custom-notifications >=20 > This allows Maintainers to receive notifications without being an > assigned reviewer. >=20 > Mike >=20 >> -----Original Message----- >> From: Rebecca Cran >> Sent: Wednesday, May 29, 2024 11:19 AM >> To: devel@edk2.groups.io; Kinney, Michael D = ; >> kraxel@redhat.com; Kubacki, Michael >> Subject: Re: [edk2-devel] GitHub PR Code Review process now active >> >> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote: >>> Hi Gerd, >>> >>> We can clarify the Wiki. A Maintainer has to be involved in every >>> code review. The first action a Maintainer does is verify that the >>> code change should be considered at all or rejected. Then add >>> maintainers for the ones that look like good submissions. >>> >>> I agree that this may add a bit of delay. You are welcome to add >>> a comment with @ tags to the maintainers and reviewers so >>> they know to look at it and do the assignments. If you like that >>> idea we can add that to the Wiki as well. >>> >>> Since PRs can be also opened by outside contributors that have >>> limited access, maintainers have to be involved in reviewing newly >>> submitted PRs. >> >> "Then add maintainers for the ones that look like good submissions." >> >> Surely in order for the maintainers to know the PR should be looked at >> in the first place they need to already be added? >> >> -- >> >> Rebecca Cran >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119362): https://edk2.groups.io/g/devel/message/119362 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-