From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.68; helo=mail-wr1-f68.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CCFD8211C7F34 for ; Wed, 6 Feb 2019 14:30:19 -0800 (PST) Received: by mail-wr1-f68.google.com with SMTP id z18so8652121wrh.2 for ; Wed, 06 Feb 2019 14:30:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v+/3tcmrK5tmZbd1KIY8xJfNvW/hy8UKmH7M7ZZAhGI=; b=VOGkImdCjexbEGz9OzQCs+F8LqFH5PypWiIvi6bdZzGS3HQpVFnHR6/JkYE6p+tPbS rXWzIeCgBaZ/3kWwuYTCP3NcOnbThCOCzSgPE5SK4mq1VsIOdsEjRWsenI5SNow6QfYM i90LVcarX0Q06g7B2d/CciDF83C5ZglOb6GzSjRhkduplnmuyiAOQjaF0ZaQNs5BACuO rOBoGdxcV3Wwo32jc6Qrds9wnQ2fb6NexirHN9izCXE0aNgRMWoztZKHJ/uh6lq8XC9L h/qu9yLEedbaX6BerVm9sUFgKUPvtApnTOnK5ZUWKdBuCtIuLddgvGgz/9VX9oegAtmf KiTA== X-Gm-Message-State: AHQUAuapbSxaaJMD2aKo5DTmTWRlv1xiNuT/iIOHjFTTDd3L04+crsSj rNzZt4haHzOYKu+DVWkFZ3Lh0Q== X-Google-Smtp-Source: AHgI3Iaadjyv2qT5qZL6JzTOgCfFx0zii0IaPbbyXvLhp/1+OeV1hcD6rdMNMdZlfpMVnDNnM2JCRA== X-Received: by 2002:adf:f1c5:: with SMTP id z5mr9749048wro.118.1549492218192; Wed, 06 Feb 2019 14:30:18 -0800 (PST) Received: from [192.168.1.103] (10.red-83-35-153.dynamicip.rima-tde.net. [83.35.153.10]) by smtp.gmail.com with ESMTPSA id g25sm3267093wmh.25.2019.02.06.14.30.17 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 14:30:17 -0800 (PST) To: Antoine Coeur , edk2-devel@lists.01.org References: Cc: Laszlo Ersek From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <280bb5d0-e01c-022e-6a02-6b744f61f28d@redhat.com> Date: Wed, 6 Feb 2019 23:30:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] CryptoPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 22:30:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Antoine, On 2/6/19 6:24 PM, Antoine Coeur wrote: > Fix various typos in CryptoPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > index d63c23df09..540c5715cb 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > @@ -142,7 +142,7 @@ IMPLEMENT_ASN1_FUNCTIONS (TS_TST_INFO) > @param[in] Asn1Time Pointer to the ASN.1 GeneralizedTime to be converted. > @param[out] SigningTime Return the corresponding EFI Time. > > - @retval TRUE The time convertion succeeds. > + @retval TRUE The time conversion succeeds. The typos are indeed fixed, so: Reviewed-by: Philippe Mathieu-Daude However reading this description makes me suspicious, I'd have written "The time convertion succeeded.", but I'm not native English speaker so I'll let someone with more insurance opinate. Regards, Phil. > @retval FALSE Invalid parameters. > > **/ > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > index 9510a4a383..929e3fcd1e 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > @@ -84,14 +84,14 @@ QuickSortWorker ( > } > } > // > - // Swap pivot to it's final position (NextSwapLocaiton) > + // Swap pivot to it's final position (NextSwapLocation) > // > CopyMem (Buffer, Pivot, ElementSize); > CopyMem (Pivot, (UINT8 *)BufferToSort + (NextSwapLocation * ElementSize), ElementSize); > CopyMem ((UINT8 *)BufferToSort + (NextSwapLocation * ElementSize), Buffer, ElementSize); > > // > - // Now recurse on 2 paritial lists. Neither of these will have the 'pivot' element. > + // Now recurse on 2 partial lists. Neither of these will have the 'pivot' element. > // IE list is sorted left half, pivot element, sorted right half... > // > QuickSortWorker ( >