From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mx.groups.io with SMTP id smtpd.web09.519.1619215572277095235 for ; Fri, 23 Apr 2021 15:06:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=fCC4KEeW; spf=pass (domain: nuviainc.com, ip: 209.85.166.52, mailfrom: rebecca@nuviainc.com) Received: by mail-io1-f52.google.com with SMTP id q25so6805054iog.5 for ; Fri, 23 Apr 2021 15:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZP4o2c311qEh6NhoxLQiky+efUrG8XjYlHq0zhR2GTM=; b=fCC4KEeW0hUp/CO9ReEZXiM5L3IX9Qe88jahcOnuyUS0ZltIPp3c3lrySlUubBd4KQ mkw2yIxdLKt/fXOvZncd84CiJ1PYtWjwNrUEWYW0dhkGgUBdsVVEVj23L5vTQg4B5iD8 BpTGgoPU1W6hcnev38QrAnxd30BttVFSdTAvBLMLQMMr0prIZxXZyvbrNoep+ZOBwlaU /VcvpZG15oM6HoFOp/fbPWUou0CEL/A2PCXup5SUdILBEJJdUzDLQ0Zvnhcs+i5q3qs2 2u5TKhPSQ1VNZ6feMMXN/x8IGk3t3r6C9ngUrIZwN9uphJMkjL1/aB2Sf9BtpBQvpMXG tbPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZP4o2c311qEh6NhoxLQiky+efUrG8XjYlHq0zhR2GTM=; b=q0mpejzkD5Ek4SXXopnH0ewIZuLG/zid/Cesz1o+3ZJfYHNvKGkFs0QPV1Zf+svR5d k1sF3ttaqEz/nKJ0YFurjv27jPlBsx8wM3mZuLPL11Ty7r8T4kFHIElDpYYjwwn6Vm2K 3HYBvBIGkhCTMCZ0eXV3+lFnovFPMS8BmjiYoXJ3rGswfeqX9aCOiOFiiHc1DwvH+rOF B16OXMVpwWXAzeavUoegT+JewUQaxV/cHAJ8xumdXeSygqp6yuAP3kV0FTrBpDdqFrzA wk/ndgHdaPefIBYFC7boHhga6skmKUi/OgsmvSCKOekFSPIb48ZIIwyKG5jYtQ7JnaS4 +8OA== X-Gm-Message-State: AOAM533mZIjSW1UWWtJq8x5G5MLSzFZJptvUL2vvwwQ8Yq1YW9u8AKpr gUPAzAEAhpWwWjHsQAZ9dCaFmQ== X-Google-Smtp-Source: ABdhPJzM+VkYNOKUBZF58YGHOzM6T6YjGkBKFQl0CJpYLkoJn+s8LPJQIMx5Q2XhjxkCULZPi+Qg0A== X-Received: by 2002:a02:90cd:: with SMTP id c13mr5483080jag.18.1619215571717; Fri, 23 Apr 2021 15:06:11 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id b12sm3106204iln.58.2021.04.23.15.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 15:06:11 -0700 (PDT) Subject: Re: [edk2-platforms PATCH v2 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki References: <20210423215719.5256-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <2818bee5-6d17-786f-22f9-6b31ebdf3b70@nuviainc.com> Date: Fri, 23 Apr 2021 16:06:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210423215719.5256-1-rebecca@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit v2 has no changes other than adding a newline at the end of Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c and reverting the change to SbsaQemu.dec. -- Rebecca Cran On 4/23/21 3:57 PM, Rebecca Cran wrote: > Add new SMBIOS Type 32 boot information and Type 3 chassis status > functions that have been added to OemMiscLib in ArmPkg. > > Since this is a virtual platform, return fixed values for the chassis > statuses. > > Signed-off-by: Rebecca Cran > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 ++++++++++++++++++++ > 1 file changed, 91 insertions(+) > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > index eb405b259848..326bb56bcfa3 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > @@ -239,3 +239,94 @@ OemUpdateSmbiosInfo ( > HiiSetString (HiiHandle, TokenToUpdate, String, NULL); > } > } > + > +/** Fetches the Type 32 boot information status. > + > + @return Boot status. > +**/ > +MISC_BOOT_INFORMATION_STATUS_DATA_TYPE > +EFIAPI > +OemGetBootStatus ( > + VOID > + ) > +{ > + return BootInformationStatusNoError; > +} > + > +/** Fetches the chassis status when it was last booted. > + > + @return Chassis status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisBootupState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis power supply/supplies status when last booted. > + > + @return Chassis power supply/supplies status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisPowerSupplyState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis thermal status when last booted. > + > + @return Chassis thermal status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisThermalState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis security status when last booted. > + > + @return Chassis security status. > +**/ > +MISC_CHASSIS_SECURITY_STATE > +EFIAPI > +OemGetChassisSecurityStatus ( > + VOID > + ) > +{ > + return ChassisSecurityStatusNone; > +} > + > +/** Fetches the chassis height in RMUs (Rack Mount Units). > + > + @return The height of the chassis. > +**/ > +UINT8 > +EFIAPI > +OemGetChassisHeight ( > + VOID > + ) > +{ > + return 1U; > +} > + > +/** Fetches the number of power cords. > + > + @return The number of power cords. > +**/ > +UINT8 > +EFIAPI > +OemGetChassisNumPowerCords ( > + VOID > + ) > +{ > + return 1; > +} >