From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 45C34740034 for ; Sun, 4 Feb 2024 02:58:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mAGbd/V7J4A9HT8lRVgolGwuFWP7PAmo7PLqSY/77bI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1707015490; v=1; b=Z65WVhtYr8mZUBuUwCBnOvdp/9tOjH9FJ+jJcn8beK3J7ecvVV+1oqjVhU4HHwY3As3MUpFE UyakQLjPlfn0EptW+FLDIBeX8v6KfQ1eVPEYExINZh+wZoz4WXKbmDbD+Ko9RQQ+YMgFy0mBu3p ABVJA7Dvlv9onXx8NZKlDDrw= X-Received: by 127.0.0.2 with SMTP id nMvoYY7687511xf35pRNJNwR; Sat, 03 Feb 2024 18:58:10 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.31662.1707015488784503521 for ; Sat, 03 Feb 2024 18:58:09 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxWPA8_b5lGoAKAA--.29801S3; Sun, 04 Feb 2024 10:58:04 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxLs86_b5lbiEvAA--.46285S3; Sun, 04 Feb 2024 10:58:03 +0800 (CST) Message-ID: <2824b44e-f1b1-4284-9573-6fa3ccc880ed@loongson.cn> Date: Sun, 4 Feb 2024 10:58:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg To: Leif Lindholm , Pedro Falcato Cc: devel@edk2.groups.io, Laszlo Ersek , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Baoqi Zhang , Dongyan Qian , Xianglai Li , Bibo Mao , Andrew Fish , "Kinney, Michael D" References: <20240126062715.3099433-1-lichao@loongson.cn> <20240126062919.3101691-1-lichao@loongson.cn> <3fe0fda8-d32e-679e-2f71-6cc35e7772b8@redhat.com> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8BxLs86_b5lbiEvAA--.46285S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQARCGW9+WIC4gABs6 X-Coremail-Antispam: 1Uk129KBj93XoWxAFWDKw4fCryrXw15XF4DKFX_yoWrJw1rpF Z5KanFyFWDAF92y3s2vw48X34Iyrn3J343tr95GrWUA3s8Wws2qryIvFyF93W7Grs3K3yj qFZ2qFyUCFyDZFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyGb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUJVWUGw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43 ZEXa7IU1njjDUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sdcRjk8uySOpAAJvDPTIE5cHx7686176AA= Content-Type: multipart/alternative; boundary="------------GCug352fIAeJSwGGDK0PRFCO" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Z65WVhtY; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------GCug352fIAeJSwGGDK0PRFCO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Leif and Pedro, Thanks, Chao On 2024/2/2 23:14, Leif Lindholm wrote: > On 2024-02-01 19:36, Pedro Falcato wrote: >> On Thu, Feb 1, 2024 at 3:05 AM Chao Li wrote: >>> >>> Hi Pedro and Laszlo, >>> >>> Part of the code in this patch is indeed quoted from the Linux >>> kernel, and do you think it is inapproparate? If so, we need to >>> refactor this module, what are you suggests with the refactoring? >>> Just remove the unused logic from the Kernel code and keep the logic >>> good or refactor from scratch? >> >> +CC stewards >> >> Disclaimer: I'm not a lawyer >> >> It is wildly inappropriate. All of the code was clearly inspired by >> GPL and derives from the Linux GPL code, it's not just unused logic. >> You should triple check *every other patch* you've sent out for these >> kinds of GPL violations. > > I want to highlight > https://github.com/tianocore/edk2/blob/master/ReadMe.rst?plain=1#L177 > > Chao, by adding your Signed-off-by to any patch and sending it out, > you certify that: > > (a) The contribution was created in whole or in part by me and I >     have the right to submit it under the open source license >     indicated in the file; or > > (b) The contribution is based upon previous work that, to the best >     of my knowledge, is covered under an appropriate open source >     license and I have the right under that license to submit that >     work with modifications, whether created in whole or in part >     by me, under the same open source license (unless I am >     permitted to submit under a different license), as indicated >     in the file; or > > (c) The contribution was provided directly to me by some other >     person who certified (a), (b) or (c) and I have not modified >     it. > > (d) I understand and agree that this project and the contribution >     are public and that a record of the contribution (including all >     personal information I submit with it, including my sign-off) is >     maintained indefinitely and may be redistributed consistent with >     this project or the open source license(s) involved. > > Now, that's a bunch of legalese, but it matters. > Mistakes happen, but it would have been a massive headache if this had > been merged and *then* we found out about this. The *best case* > scenario would have been that we would have been forced to revert the > whole set. > > I wouldn't say you need to "triple check every patch", but I would say > you need to re-evaluate the existing patches based on this new > information you have learned. So that once you resubmit a version as > per Laszlos comments in separate email, you are comfortable that the > whole submission conforms with the DCO. > And if you are unsure - ask. That's never wrong. > > Pedro - many thanks for this. Owe you one. Of couse, I will study the entries you are referring to and I'm sure that the Part 1 series is full compliance with terms, and I will double/triple check them when I sumbit the Part 2, thank you for spotting this and preventing me form making a mistake. > > / >     Leif > >> There's another way of writing this sort of code (that doesn't involve >> all the Linux mm craziness) but I don't know if changing strategies >> would be considered getting rid of any shadow of GPL/IP violation. >> >> (As a side note, I don't really understand IP in the software world. >> If you work, say, on GPL software for a moment in time, are you always >> going to be "GPL-tainted"? Surely not? Most people in the industry >> I've talked to about this say that, yeah, no, corps don't expect that. >> But no one really seems to have drawn a line between OK and not-OK, >> but rather "please please don't sue us". And in this case I don't know >> (but I suspect it'd be uncomfortable) for someone to redesign a >> solution right away, after being "tainted". Anyway, tough problem, and >> IANAL :/) >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115077): https://edk2.groups.io/g/devel/message/115077 Mute This Topic: https://groups.io/mt/103971653/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------GCug352fIAeJSwGGDK0PRFCO Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Leif and Pedro,


Thanks,
Chao
On 2024/2/2 23:14, Leif Lindholm wrote:
On 2024-02-01 19:36, Pedro Falcato wrote:
On Thu, Feb 1, 2024 at 3:05 AM Chao Li <lichao@loongson.cn> wrote:

Hi Pedro and Laszlo,

Part of the code in this patch is indeed quoted from the Linux kernel, and do you think it is inapproparate? If so, we need to refactor this module, what are you suggests with the refactoring? Just remove the unused logic from the Kernel code and keep the logic good or refactor from scratch?

+CC stewards

Disclaimer: I'm not a lawyer

It is wildly inappropriate. All of the code was clearly inspired by
GPL and derives from the Linux GPL code, it's not just unused logic.
You should triple check *every other patch* you've sent out for these
kinds of GPL violations.

I want to highlight
https://github.com/tianocore/edk2/blob/master/ReadMe.rst?plain=1#L177

Chao, by adding your Signed-off-by to any patch and sending it out, you certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Now, that's a bunch of legalese, but it matters.
Mistakes happen, but it would have been a massive headache if this had been merged and *then* we found out about this. The *best case* scenario would have been that we would have been forced to revert the whole set.

I wouldn't say you need to "triple check every patch", but I would say you need to re-evaluate the existing patches based on this new information you have learned. So that once you resubmit a version as per Laszlos comments in separate email, you are comfortable that the whole submission conforms with the DCO.
And if you are unsure - ask. That's never wrong.

Pedro - many thanks for this. Owe you one.
Of couse, I will study the entries you are referring to and I'm sure that the Part 1 series is full compliance with terms, and I will double/triple check them when I sumbit the Part 2, thank you for spotting this and preventing me form making a mistake.

/
    Leif

There's another way of writing this sort of code (that doesn't involve
all the Linux mm craziness) but I don't know if changing strategies
would be considered getting rid of any shadow of GPL/IP violation.

(As a side note, I don't really understand IP in the software world.
If you work, say, on GPL software for a moment in time, are you always
going to be "GPL-tainted"? Surely not? Most people in the industry
I've talked to about this say that, yeah, no, corps don't expect that.
But no one really seems to have drawn a line between OK and not-OK,
but rather "please please don't sue us". And in this case I don't know
(but I suspect it'd be uncomfortable) for someone to redesign a
solution right away, after being "tainted". Anyway, tough problem, and
IANAL :/)

_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#115077) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------GCug352fIAeJSwGGDK0PRFCO--