Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

["Leif Lindholm" <quic_llindhol@quicinc.com>]

(Dropping direct cc:s)

On 2024-07-01 20:16, Rebecca Cran wrote:
> Now that edk2 has been using PRs for a few weeks, I'd like to propose 
> enabling the same workflow for edk2-platfoms.
> 
> As maintainers or reviewers of platforms in the edk2-platforms repo, I'd 
> like to get any feedback on moving from email-based reviews to GitHub 
> Pull Requests and any concerns or issues people might have with it.

My only concern is wrt reviewer assignment.

There are a few ways we can consider that - for example:
- leave contribution workflow up to each maintainer (for now)
- switch fully and expect maintainers to dutifully trawl the PR queue
- Move to CODEOWNERS for edk2-platforms (which has less complex wildcard
   use than edk2)

Best Regards,

Leif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119749): https://edk2.groups.io/g/devel/message/119749
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-