From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 95E92740034 for ; Mon, 1 Jul 2024 20:13:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VeGa8OZ8bBLUu96HNfRPhcOccmXNAwK05mrlaGEnvXo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1719864829; v=1; b=t0prdEH88vpo+vnnOrPO0K3C7McNSZ6APmTPeV2xh/vjFDL7GZT9xfpDMPFRFAj6L7z07jSN Zx4fRzH2+n6xozG/+4hO346+5Tj2F3hesT/GydTUDqZ+gZrIAeFRnxIEwhx/XXxlabOvBjoNXnK yQytg8dzDrZf9KX6Ix9zCrzFzoTJ2fMOrp3LFDOTn2hWWk7OtkB3VuWNCUXCP03/7F7Ywm8TLVX L6XxvK3VOOIWyxOPugC/z3bzEDTDoIK00ng3g4q5zg6KGWyqdCGBycBJyPXk1BZTq2AUQ5b/H3z iRxqZHLzauK8zA9hq5suqxoR6gsKTcfGL30xqTqpuk0Tw== X-Received: by 127.0.0.2 with SMTP id LN4gYY7687511xKLdQSqj6R0; Mon, 01 Jul 2024 13:13:47 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.7165.1719864827326570183 for ; Mon, 01 Jul 2024 13:13:47 -0700 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 461BNJ3u010888; Mon, 1 Jul 2024 20:13:44 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 403kj8td69-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Jul 2024 20:13:44 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 461KDi5c004803 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Jul 2024 20:13:44 GMT X-Received: from [10.111.143.246] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 1 Jul 2024 13:13:42 -0700 Message-ID: <28301d08-9e6b-4a2d-ba78-8e714345bd30@quicinc.com> Date: Mon, 1 Jul 2024 21:13:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests To: Rebecca Cran , CC: Michael D Kinney References: <71e26999-15bb-4b74-b884-e20480ba92f6@bsdio.com> From: "Leif Lindholm" In-Reply-To: <71e26999-15bb-4b74-b884-e20480ba92f6@bsdio.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: Sgv3dhki0JO4NGVkFjuME1HdRb2C3S_a X-Proofpoint-ORIG-GUID: Sgv3dhki0JO4NGVkFjuME1HdRb2C3S_a Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Jul 2024 13:13:47 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cWCksAfijkWGxypYRqQMwxQ8x7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=t0prdEH8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io (Dropping direct cc:s) On 2024-07-01 20:16, Rebecca Cran wrote: > Now that edk2 has been using PRs for a few weeks, I'd like to propose=20 > enabling the same workflow for edk2-platfoms. >=20 > As maintainers or reviewers of platforms in the edk2-platforms repo, I'd= =20 > like to get any feedback on moving from email-based reviews to GitHub=20 > Pull Requests and any concerns or issues people might have with it. My only concern is wrt reviewer assignment. There are a few ways we can consider that - for example: - leave contribution workflow up to each maintainer (for now) - switch fully and expect maintainers to dutifully trawl the PR queue - Move to CODEOWNERS for edk2-platforms (which has less complex wildcard use than edk2) Best Regards, Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119749): https://edk2.groups.io/g/devel/message/119749 Mute This Topic: https://groups.io/mt/106986207/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-