From: "Laszlo Ersek" <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Oliver Steffen <osteffen@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Michael Roth <michael.roth@amd.com>, Min Xu <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 2/3] OvmfPkg/ResetVector: add 5-level paging support
Date: Tue, 30 Jan 2024 17:48:28 +0100 [thread overview]
Message-ID: <2855fc7e-1cff-02ab-7035-47c1dd1833a5@redhat.com> (raw)
In-Reply-To: <ji3rualrzcbkab2kcyeq2wr4hffqbr247lqbutntbj5fmced5p@u22kfos5x66p>
On 1/30/24 10:14, Gerd Hoffmann wrote:
>> (3) While the macro PAGE_2M_PDE_ATTR might expand to just the right
>> constant here, the "2M" in the name is extremely confusing. Please
>> introduce a new macro for selecting 1GB pages.
>
> I think rename "2M" to "LARGEPAGE" would be better here. The page
> directory bit essentially says "stop page table walk here, there are no
> page tables/page directories below this". When set in a 4-level page
> directory you'll get a 2M page, when set in a 3-level page directory
> you'll get a 1G page.
*Great* idea; please do that! (Please also include this great
explanation near the changed macro, in the source code!)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114804): https://edk2.groups.io/g/devel/message/114804
Mute This Topic: https://groups.io/mt/104029639/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-30 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 12:01 [edk2-devel] [PATCH 0/3] OvmfPkg: Add support for 5-level paging Gerd Hoffmann
2024-01-29 12:01 ` [edk2-devel] [PATCH 1/3] MdeModulePkg: fix PcdUse5LevelPageTable assert Gerd Hoffmann
2024-01-29 20:15 ` Laszlo Ersek
2024-01-29 12:02 ` [edk2-devel] [PATCH 2/3] OvmfPkg/ResetVector: add 5-level paging support Gerd Hoffmann
2024-01-29 21:04 ` Laszlo Ersek
2024-01-30 9:14 ` Gerd Hoffmann
2024-01-30 16:48 ` Laszlo Ersek [this message]
2024-01-29 12:02 ` [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformInitLib: " Gerd Hoffmann
2024-01-29 21:12 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2855fc7e-1cff-02ab-7035-47c1dd1833a5@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox