Hi Ard,

 

Thank you for this patch.

 

These changes look good to me.

 

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

 

In addition to this patch I required the following changes for the FVP to boot to the UEFI shell.

 

edk2 repo:

-----------

diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf b/ArmPlatformPkg/PeilessSec/PeilessSec.inf
index 7ceeb74f69f2..d652b72e46b9 100644
--- a/ArmPlatformPkg/PeilessSec/PeilessSec.inf
+++ b/ArmPlatformPkg/PeilessSec/PeilessSec.inf
@@ -43,6 +43,7 @@ [LibraryClasses]
   DebugAgentLib
   DebugLib
   HobLib
+  LzmaDecompressLib
   MemoryInitPeiLib
   PerformanceLib
   PlatformPeiLib

 

 

edk2-platforms repo:

---------------------

diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index 931eff2355d4..a299d7ed559a 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -194,6 +194,7 @@ [LibraryClasses.common.SEC]
 !ifdef $(EDK2_SKIP_PEICORE)
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
   ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
+  LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
   MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
   HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
   PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf

 

Without the above change the "SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF" is not found, see https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf#L250

 

Regards,

 

Sami Mujawar

_._,_._,_

_._,_._,_