From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 72847AC1812 for ; Fri, 30 Aug 2024 15:46:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vMki82CLTyr8xWoeTtzrMSjC4AM/bkvBxXZ2zJGhByE=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1725032760; v=1; b=hC9n0bx7QK73Xhvrp0ALUeE/Gl2WVIhOHHh0IJrgCvx0rwNft7jOqCtnJezk/JTcG6nfnTE6 9EU54sUDMX7Y/fjXkOXY5gfszvANSg9r+fer6tVxTfnZFKw1P+R5zeQF1I+fFjzvPBxBlXV+iDR PKq5/rQVoVFlBVlwiqBBYMTZ7wSxXpP9WWiZHxQlByCjxMksl/JPoJxW6xOYGwEMFPR78rjVWrm NUcA7ZVFbu+7BD/E1+SlNEHP6ZPYyv6c2KG/LDUkvl7gX+aEaQQ4o5B1zrUQTntftqVcYuo1RpV J+fVvY+34RUliqr+rll6og4Bq1aTveXotDT9YklD9HI5g== X-Received: by 127.0.0.2 with SMTP id gxrNYY7687511xILYdralbPm; Fri, 30 Aug 2024 08:45:58 -0700 Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/VExpress: Replace missing ArmGetCpuCountPerCluster() To: "Ard Biesheuvel" , devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.50) X-Originating-Platform: Mac Safari 17.6 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 30 Aug 2024 08:45:58 -0700 References: <20240827172820.661646-1-ardb+git@google.com> In-Reply-To: <20240827172820.661646-1-ardb+git@google.com> Message-ID: <28815.1725032758218981318@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: r5zpDlioV6oMUDNFkBqPpeRjx7686176AA= Content-Type: multipart/alternative; boundary="mye56p48vIt7MtkySAyZ" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=hC9n0bx7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --mye56p48vIt7MtkySAyZ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Ard, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar In addition to this patch I required the following changes for the FVP to b= oot to the UEFI shell. edk2 repo: ----------- diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf b/ArmPlatformPkg/Peil= essSec/PeilessSec.inf index 7ceeb74f69f2..d652b72e46b9 100644 --- a/ArmPlatformPkg/PeilessSec/PeilessSec.inf +++ b/ArmPlatformPkg/PeilessSec/PeilessSec.inf @@ -43,6 +43,7 @@ [LibraryClasses] DebugAgentLib DebugLib HobLib + =C2=A0LzmaDecompressLib MemoryInitPeiLib PerformanceLib PlatformPeiLib edk2-platforms repo: --------------------- diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VE= xpressPkg/ArmVExpress.dsc.inc index 931eff2355d4..a299d7ed559a 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc @@ -194,6 +194,7 @@ [LibraryClasses.common.SEC] !ifdef $(EDK2_SKIP_PEICORE) PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/Pr= ePiExtractGuidedSectionLib.inf + =C2=A0LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/Lzma= CustomDecompressLib.inf MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemor= yAllocationLib.inf HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiH= obListPointerLib.inf Without the above change the "SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD7= 9403CF" is not found, see https://github.com/tianocore/edk2-platforms/blob/= master/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf#L250 Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120448): https://edk2.groups.io/g/devel/message/120448 Mute This Topic: https://groups.io/mt/108128468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --mye56p48vIt7MtkySAyZ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi Ard,
 
Thank you for this patch.
 
These changes look good to me.
 
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
 
In addition to this patch I required the following changes for the FVP= to boot to the UEFI shell.
 
edk2 repo:
-----------
diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf b/ArmPlatformPkg= /PeilessSec/PeilessSec.inf
index 7ceeb74f69f2..d652b72e46b9 100644
--- a/ArmPlatformPkg/PeilessSec/PeilessSec.inf
+++ b/ArmPlatformPkg/= PeilessSec/PeilessSec.inf
@@ -43,6 +43,7 @@ [LibraryClasses]
&nbs= p;  DebugAgentLib
   DebugLib
   HobLib<= br />+  LzmaDecompressLib
   MemoryInitPeiLib
&nbs= p;  PerformanceLib
   PlatformPeiLib
 
 
edk2-platforms repo:
---------------------
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/A= RM/VExpressPkg/ArmVExpress.dsc.inc
index 931eff2355d4..a299d7ed559a 10= 0644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Pla= tform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -194,6 +194,7 @@ [Library= Classes.common.SEC]
 !ifdef $(EDK2_SKIP_PEICORE)
  &nbs= p;PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
   Extr= actGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiE= xtractGuidedSectionLib.inf
+  LzmaDecompressLib|MdeModulePkg/Libr= ary/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
   M= emoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemory= AllocationLib.inf
   HobLib|EmbeddedPkg/Library/PrePiHobLib/= PrePiHobLib.inf
   PrePiHobListPointerLib|ArmPlatformPkg/Lib= rary/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
 
Without the above change the "SECTION GUIDED EE4E5898-3914-4259-9D6E-D= C7BD79403CF" is not found, see https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM= /VExpressPkg/ArmVExpress-FVP-AArch64.fdf#L250
 
Regards,
 
Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120448) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--mye56p48vIt7MtkySAyZ--