From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F28C21A1DF1 for ; Mon, 26 Sep 2016 03:06:11 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F74520278; Mon, 26 Sep 2016 10:06:10 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-12.phx2.redhat.com [10.3.116.12]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8QA67mN005718; Mon, 26 Sep 2016 06:06:09 -0400 To: Ruiyu Ni , edk2-devel@ml01.01.org References: <20160926093035.350612-1-ruiyu.ni@intel.com> <20160926093035.350612-14-ruiyu.ni@intel.com> Cc: Ard Biesheuvel From: Laszlo Ersek Message-ID: <28a7843f-a178-c8e0-bb85-8d46ef8bd90b@redhat.com> Date: Mon, 26 Sep 2016 12:06:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160926093035.350612-14-ruiyu.ni@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 26 Sep 2016 10:06:11 +0000 (UTC) Subject: Re: [PATCH v2 13/19] ArmVirtPkg/PlatformBds: Do not call BootLogoEnableLogo X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 10:06:12 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/26/16 11:30, Ruiyu Ni wrote: > Prototype of BootLogoEnableLogo will change in following patches, so > do not call BootLogoEnableLogo to avoid build failure. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Ruiyu Ni > --- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 14 +++++++------- > .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 - > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c > index c11196a..5d7c2a4 100644 > --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -657,13 +657,13 @@ PlatformBootManagerAfterConsole ( > // > // Show the splash screen. > // > - BootLogoEnableLogo ( > - ImageFormatBmp, // ImageFormat > - PcdGetPtr (PcdLogoFile), // Logo > - EdkiiPlatformLogoDisplayAttributeCenter, // Attribute > - 0, // OffsetX > - 0 // OffsetY > - ); > + // BootLogoEnableLogo ( > + // ImageFormatBmp, // ImageFormat > + // PcdGetPtr (PcdLogoFile), // Logo > + // EdkiiPlatformLogoDisplayAttributeCenter, // Attribute > + // 0, // OffsetX > + // 0 // OffsetY > + // ); > > // > // Connect the rest of the devices. > diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index bec7fab..1f162c6 100644 > --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > @@ -58,7 +58,6 @@ [LibraryClasses] > UefiRuntimeServicesTableLib > > [FixedPcd] > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits > Reviewed-by: Laszlo Ersek