From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id BE322211F8899
 for <edk2-devel@lists.01.org>; Thu, 12 Jul 2018 14:42:59 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 265CA404008D;
 Thu, 12 Jul 2018 21:42:58 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-124-188.rdu2.redhat.com
 [10.10.124.188])
 by smtp.corp.redhat.com (Postfix) with ESMTP id D73011102E24;
 Thu, 12 Jul 2018 21:42:56 +0000 (UTC)
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
 "Justen, Jordan L" <jordan.l.justen@intel.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "Gao, Liming" <liming.gao@intel.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Zhang, Chao B" <chao.b.zhang@intel.com>
References: <20180710225105.28443-1-roman.bacik@broadcom.com>
 <5bca3f43-7c23-dca6-03cd-2d647d8fe253@redhat.com>
 <CAGQAs7wNF4KXiHGJmZzKZYCBDLm-dFbJktxQ2nX5Nihk4EdUdA@mail.gmail.com>
 <fa31fa72-59f5-3e47-026b-3673787b2b81@redhat.com>
 <415f1063-7a67-b5ec-cc84-83e1b36cb46a@redhat.com>
 <995927A3-8CBC-4E92-B1B5-5DCEA451328D@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <28ca9fe6-33f2-90a6-482a-2fcbf84e154c@redhat.com>
Date: Thu, 12 Jul 2018 23:42:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <995927A3-8CBC-4E92-B1B5-5DCEA451328D@intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.5]); Thu, 12 Jul 2018 21:42:58 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]);
 Thu, 12 Jul 2018 21:42:58 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2018 21:43:00 -0000
Content-Type: text/plain; charset=iso-2022-jp
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/12/18 14:07, Yao, Jiewen wrote:
> thanks laszlo 
> I like your idea to eliminate the code duplication and fix all the problem by adding a new api in uefi lib. 
> 
> If there is urgency to fix this specific issue, I have no problem on the enhancement. 
> 
> Reviewed by : Jiewen.yao@intel.com
> 
> thank you!
> Yao, Jiewen

Commit 79b10d4ce4f0.

Thanks all!
Laszlo