From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 16A3921E2DA51 for ; Tue, 15 Aug 2017 17:39:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 199111F598; Wed, 16 Aug 2017 00:41:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 199111F598 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-68.phx2.redhat.com [10.3.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id CAFB34F291; Wed, 16 Aug 2017 00:41:29 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-6-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <28d0dddc-bc4c-ba7c-32bc-aacad033bd5f@redhat.com> Date: Wed, 16 Aug 2017 02:41:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502710605-8058-6-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 16 Aug 2017 00:41:31 +0000 (UTC) Subject: Re: [PATCH v2 05/23] OvmfPkg/Virtio: fix comment style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 00:39:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/14/17 13:36, Brijesh Singh wrote: > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Include/Protocol/VirtioDevice.h | 22 +++++++++++++------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/OvmfPkg/Include/Protocol/VirtioDevice.h b/OvmfPkg/Include/Protocol/VirtioDevice.h > index 910a4866e7ac..edb20c18822c 100644 > --- a/OvmfPkg/Include/Protocol/VirtioDevice.h > +++ b/OvmfPkg/Include/Protocol/VirtioDevice.h > @@ -320,16 +320,22 @@ EFI_STATUS > ); > > > -/// > -/// This protocol provides an abstraction over the VirtIo transport layer > -/// > -/// DISCLAIMER: this protocol is a work in progress, and should not be used > -/// outside of the EDK II tree. > -/// > +/** > + > + This protocol provides an abstraction over the VirtIo transport layer > + > + DISCLAIMER: this protocol is a work in progress, and should not be used > + outside of the EDK II tree. > +**/ > + > struct _VIRTIO_DEVICE_PROTOCOL { > - /// VirtIo Specification Revision encoded with VIRTIO_SPEC_REVISION() > + // > + // VirtIo Specification Revision encoded with VIRTIO_SPEC_REVISION() > + // > UINT32 Revision; > - /// From the Virtio Spec > + // > + // From the Virtio Spec > + // > INT32 SubSystemDeviceId; > > VIRTIO_GET_DEVICE_FEATURES GetDeviceFeatures; > In , point (18), I meant to identify all the comments that I thought would benefit from clean-ups. The above patch misses some of those comments, but reformats comments that (IMO) were fine (e.g. consistent with MdePkg protocol includes). I've fixed up the patch. [lersek@redhat.com: clarify subject line] [lersek@redhat.com: adjust the set of comments updated by the patch] Reviewed-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek Commit a136bc3ccfa479ec8a3fc9afcbd00283339101fa. Thank you for these miscellaneous fixes (patches 1 through 5)! I'll strive to continue the review soon. Thanks Laszlo