From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC34F21959CB2 for ; Mon, 5 Nov 2018 08:45:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E551C58E27; Mon, 5 Nov 2018 16:45:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-125-224.rdu2.redhat.com [10.10.125.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2440010840C1; Mon, 5 Nov 2018 16:45:38 +0000 (UTC) To: Shenglei Zhang , edk2-devel@lists.01.org References: <20181105030807.27420-1-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <28d24cc6-1aa0-53f4-eb1a-32792956e970@redhat.com> Date: Mon, 5 Nov 2018 17:45:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181105030807.27420-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 05 Nov 2018 16:45:39 +0000 (UTC) Subject: Re: [PATCH v3 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 16:45:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/05/18 04:08, Shenglei Zhang wrote: > Remove EdkShellBinPkg in CorebootPayloadPkg, EmulatorPkg, Nt32Pkg > and OvmfPkg. Replace EdkShellBinPkg with EdkShellPkg in > Vlv2TbltDevicePkg. > > v2: Remove 'USE_OLD_SHELL' in dsc files. > > v3: Remove FULL_BIN and change SHELL_TYPE from FULL_BIN > to UEFI_BIN. > > shenglei (5): > Nt32Pkg: Remove EdkShellBinPkg in FDF,DSC and DEC > Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg > EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC > OvmfPkg: Remove EdkShellBinPkg in FDF > CorebootPayloadPkg: Remove EdkShellBinPkg in FDF > > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8 -------- > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 9 ++------- > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 9 ++------- > EmulatorPkg/EmulatorPkg.dec | 2 +- > EmulatorPkg/EmulatorPkg.dsc | 4 ---- > EmulatorPkg/EmulatorPkg.fdf | 4 ---- > Nt32Pkg/Nt32Pkg.dec | 2 +- > Nt32Pkg/Nt32Pkg.dsc | 6 ++---- > Nt32Pkg/Nt32Pkg.fdf | 4 ---- > OvmfPkg/OvmfPkgIa32.dsc | 4 ---- > OvmfPkg/OvmfPkgIa32.fdf | 4 ---- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ---- > OvmfPkg/OvmfPkgIa32X64.fdf | 4 ---- > OvmfPkg/OvmfPkgX64.dsc | 4 ---- > OvmfPkg/OvmfPkgX64.fdf | 4 ---- > Vlv2TbltDevicePkg/PlatformPkg.fdf | 5 +---- > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 5 +---- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 20 files changed, 13 insertions(+), 72 deletions(-) > In the cover letter, you have to manually CC all people from the individual patches. Please collect all the CC's from the individual patches, sort them uniquely, and add them to the cover letter. The cover letter is relevant to everyone that receives at least one patch from the series. For two reasons: - the cover letter explains the high level goal of the changes - the cover letter serves as the anchor point for collecting the patches in the series into a single thread in the MUA's threaded view. You haven't CC'd me on the cover letter, and now your patches (from three versions of the patch set) are scattered between the 300+ emails that I now have to process after being away for a little while. At least I managed to find the latest-looking (v3) cover letter in my edk2-devel list folder. Will follow up later. Laszlo