From: Laszlo Ersek <lersek@redhat.com>
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH v2 4/7] MdePkg: Remove an unused PCD
Date: Tue, 21 Aug 2018 16:09:05 +0200 [thread overview]
Message-ID: <28ea1dc8-737a-b7ba-05d1-5a8456c1f29c@redhat.com> (raw)
In-Reply-To: <20180821013548.1384-5-shenglei.zhang@intel.com>
On 08/21/18 03:35, shenglei wrote:
> The PCD below is unused, so it has been removed from inf.
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> MdePkg/Library/BaseLib/BaseLib.inf | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MdePkg/Library/BaseLib/BaseLib.inf b/MdePkg/Library/BaseLib/BaseLib.inf
> index a1b5ec4b75..4ae8a0b05a 100644
> --- a/MdePkg/Library/BaseLib/BaseLib.inf
> +++ b/MdePkg/Library/BaseLib/BaseLib.inf
> @@ -643,7 +643,6 @@
> gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength ## SOMETIMES_CONSUMES
> gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength ## SOMETIMES_CONSUMES
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## SOMETIMES_CONSUMES
> - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## SOMETIMES_CONSUMES
>
> [FeaturePcd]
> gEfiMdePkgTokenSpaceGuid.PcdVerifyNodeInList ## CONSUMES
>
Looks OK to me.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2018-08-21 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 1:35 [PATCH v2 0/7] Removed unused PCDs shenglei
2018-08-21 1:35 ` [PATCH v2 1/7] IntelFsp2Pkg: Remove " shenglei
2018-08-21 1:35 ` [PATCH v2 2/7] IntelFsp2WrapperPkg: " shenglei
2018-08-21 1:35 ` [PATCH v2 3/7] MdeModulePkg: " shenglei
2018-08-21 2:06 ` Zeng, Star
2018-08-21 1:35 ` [PATCH v2 4/7] MdePkg: Remove an unused PCD shenglei
2018-08-21 14:09 ` Laszlo Ersek [this message]
2018-08-21 1:35 ` [PATCH v2 5/7] SecurityPkg: Remove unused PCDs shenglei
2018-08-21 14:14 ` Laszlo Ersek
2018-08-21 1:35 ` [PATCH v2 6/7] ShellPkg: " shenglei
2018-08-21 14:20 ` Laszlo Ersek
2018-08-21 1:35 ` [PATCH v2 7/7] UefiCpuPkg: Remove an unused PCD shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ea1dc8-737a-b7ba-05d1-5a8456c1f29c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox