From: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
To: <devel@edk2.groups.io>
Cc: <jiangang.he@amd.com>, <abner.chang@amd.com>,
Neo Hsueh <Hong-Chih.Hsueh@amd.com>
Subject: [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM
Date: Tue, 23 May 2023 12:07:15 -0500 [thread overview]
Message-ID: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> (raw)
If there is no port multiplier, PortMultiplierPort should be converted
to 0 to follow AHCI spec.
The same logic already applied in AtaAtapiPassThruDxe driver.
Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
---
MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
index cd55272c96..7bd04661d0 100644
--- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
+++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
@@ -3,6 +3,7 @@
mode at PEI phase.
Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -92,6 +93,15 @@ AhciPassThruExecute (
{
EFI_STATUS Status;
+ if (PortMultiplierPort == 0xFFFF) {
+ //
+ // If there is no port multiplier, PortMultiplierPort will be 0xFFFF
+ // according to UEFI spec. Here, we convert its value to 0 to follow
+ // AHCI spec.
+ //
+ PortMultiplierPort = 0;
+ }
+
switch (Packet->Protocol) {
case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA:
Status = AhciNonDataTransfer (
--
2.40.0.windows.1
next reply other threads:[~2023-05-23 17:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 17:07 Neo Hsueh [this message]
2023-05-24 0:33 ` [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Chang, Abner
2023-05-31 3:29 ` [edk2-devel] " Wu, Hao A
2023-05-31 14:48 ` He, Jiangang
2023-06-02 3:14 ` Wu, Hao A
2023-06-02 14:37 ` hong-chih.hsueh
2023-06-02 16:31 ` Chang, Abner
2023-06-02 18:11 ` Hsueh, Hong-Chih (Neo)
2023-06-05 4:31 ` Wu, Hao A
2023-06-06 2:24 ` Wu, Hao A
2023-06-06 7:20 ` Chang, Abner
2023-06-07 3:21 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox