From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2095F78003C for ; Tue, 5 Mar 2024 08:53:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0fgok5fqpUP3G5jZC7HtoO3+kBSZ1jCy09fNiipiB8o=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709628825; v=1; b=surTvDlAgLB7O+JTJT6ONj7DnE4zMo8zPChfeSh8LMMdOwWM7+FGUknYAJb+pPguZgUv44xI eKCnvMPAmFgFlauQSLQCVwl+LR8Ihd99hVnEROrMXionK1RgArvLQzwpqL+tjwAOs4WCV+FPbbo uTnaPyqbKGLCY+cCpy1Y1zes= X-Received: by 127.0.0.2 with SMTP id DsrRYY7687511xWYu4T7YnoV; Tue, 05 Mar 2024 00:53:45 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.17423.1709628824864724819 for ; Tue, 05 Mar 2024 00:53:45 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-osxudS-zMCGmPdkleOWhyQ-1; Tue, 05 Mar 2024 03:53:38 -0500 X-MC-Unique: osxudS-zMCGmPdkleOWhyQ-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF24480F7EB; Tue, 5 Mar 2024 08:53:37 +0000 (UTC) X-Received: from [10.39.193.2] (unknown [10.39.193.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FE8440C6CB9; Tue, 5 Mar 2024 08:53:34 +0000 (UTC) Message-ID: <28fbbc44-cc80-e58d-f8bb-6976613dc48a@redhat.com> Date: Tue, 5 Mar 2024 09:53:33 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again To: devel@edk2.groups.io, jlee@suse.com Cc: Liming , Michael D Kinney , joeyli.kernel@gmail.com, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com References: <20240204092914.29813-1-jlee@suse.com> <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> <20240207075549.GZ21608@linux-l9pv.suse> <17B185EB8F3EA51B.19081@groups.io> <20240304113752.GK31128@linux-l9pv.suse> From: "Laszlo Ersek" In-Reply-To: <20240304113752.GK31128@linux-l9pv.suse> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6YfCnxNTtKeaXsXJX1w8nd4Kx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=surTvDlA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 3/4/24 12:37, joeyli via groups.io wrote: > Hi, >=20 > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: >> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: >>> Hi Laszlo, >>> >>> First, thanks for your review! >>> >>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: >>>> On 2/4/24 10:29, Lee, Chun-Yi wrote: >>>>> In case PcdFirmwareReleaseDateString is not set use a valid date >>>>> as fallback. But the default valid date can _NOT_ pass the Microsoft >>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emitte= d >>>>> the error message: >>>>> >>>>> BIOS Release Date string is unexpected length: 8. This string must be= in >>>>> MM/DD/YYYY format. No other format is allowed and no additional infor= mation >>>>> may be included. See field description in the SMBIOS specification. >>>>> >>>>> Base on SMBIOS spec v3.7.0: >>>>> >>>>> 08h 2.0+ BIOS Release Date BYTE STRING >>>>> String number of the BIOS release date. The date >>>>> string, if supplied, is in either mm/dd/yy or >>>>> mm/dd/yyyy format. If the year portion of the string >>>>> is two digits, the year is assumed to be 19yy. >>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS >>>>> version 2.3 and later. >>>>> >>>>> So, let's tweek the fallback release date again. >>>>> >>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback relea= se date") [edk2-stable202305~327] >>>>> Signed-off-by: "Lee, Chun-Yi" >>>>> --- >>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/= SmbiosPlatformDxe/SmbiosPlatformDxe.c >>>>> index 0ca3776045..e929da6b81 100644 >>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c >>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c >>>>> @@ -160,7 +160,7 @@ InstallAllStructures ( >>>>> DateStr =3D (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateStri= ng); >>>>> DateLen =3D StrLen (DateStr); >>>>> if (DateLen < 3) { >>>>> - DateStr =3D L"2/2/2022"; >>>>> + DateStr =3D L"02/02/2022"; >>>>> DateLen =3D StrLen (DateStr); >>>>> } >>>>> =20 >>>> >>>> Are you proposing this as an important (but low risk) bugfix that migh= t >>>> qualify for the freeze(s)? If so, please loop in Liming and Mike. >>>> >>> >>> hm... What does freeze mean?=20 >>> >> >> ah... You mean soft feature freeze for edk2-stable202402.=20 >> >> Hi Liming, Michael, >> >> This change is important but low risk. Could you please consider to add = it >> to edk2-stable202402 release? >> >> Thanks a lot! >> Joey Lee >=20 > This patch is not in edk2-stable202402. Will it to be merged to next rele= ase? Thanks for the reminder, and sorry about the delay! Merged as commit 2a0d4a2641a7, via . For future contributions: please run PatchCheck.py on the patch series before formatting and posting it (better yet, submit a personal CI build PR). Thanks Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116356): https://edk2.groups.io/g/devel/message/116356 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-