From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 09:12:11 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83A50C1EB1FE; Thu, 20 Jun 2019 16:12:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C4AA1001B17; Thu, 20 Jun 2019 16:12:04 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable To: devel@edk2.groups.io, dwmw2@infradead.org, jljusten@gmail.com, afish@apple.com, Paolo Bonzini References: <9c9d53f5da9c3dec56cff0ff07c399e3034444a1.camel@infradead.org> <584f8af7979d40fd960122fc077fad02ecce09b1.camel@infradead.org> From: "Laszlo Ersek" Message-ID: <29111f7d-0f4c-bba6-697d-c061ce1b6488@redhat.com> Date: Thu, 20 Jun 2019 18:12:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <584f8af7979d40fd960122fc077fad02ecce09b1.camel@infradead.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 20 Jun 2019 16:12:05 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/19/19 14:44, David Woodhouse wrote: > Signed-off-by: David Woodhouse > --- > OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c > index 05e3ffd2bb..69abd06c40 100644 > --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c > +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c > @@ -568,7 +568,7 @@ ShadowAndStartLegacy16 ( > // > // Skip Floppy and possible onboard IDE drives > // > - EfiToLegacy16BootTable->NumberBbsEntries = 1 + 2 * MAX_IDE_CONTROLLER; > + EfiToLegacy16BootTable->NumberBbsEntries = sizeof(Private->IntThunk->BbsTable) / sizeof(BBS_TABLE); > > for (Index = 0; Index < (sizeof (Private->IntThunk->BbsTable) / sizeof (BBS_TABLE)); Index++) { > BbsTable[Index].BootPriority = BBS_IGNORE_ENTRY; > > > > If it's possible, please write a non-empty commit message body, for each patch in this series. Just one sentence on this patch would be nice. I think your note on patch#2 is valuable too and should be captured in the commit message body. Please consider formulating it with a bit more neutral tone :) With those updates, for these pair of patches: Acked-by: Laszlo Ersek If you could submit your "csm" branch as a 3-part series (consisting of these two patches, plus "OvmfPkg: Don't build in QemuVideoDxe when we have CSM"; with my A-b's / R-b added), that would be great, I could apply & push it in one go. If you prefer an actual pullreq (not github pull req), we can "pioneer" that (for edk2 anyway) too. It will still require a posting to the list, and then I'll have to compare the commits in the topic branch (subject to the pull request) against the patches on the list. Thanks! Laszlo