public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Devon Bautista" <dbautista@newmexicoconsortium.org>
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH v1] OvmfPkg: Add build options for 8MB and 16MB X64 OVMF images
Date: Fri, 28 May 2021 13:49:24 -0700	[thread overview]
Message-ID: <29122019-b50a-4104-9b9e-8efd829ecd9d@newmexicoconsortium.org> (raw)
In-Reply-To: <db7ba678-246d-f430-b00b-817dbcaadcf4@redhat.com>

On 5/27/21 3:14 AM, Laszlo Ersek wrote:
> On 05/27/21 12:12, Laszlo Ersek wrote:
>> On 05/26/21 19:08, Devon Bautista wrote:
>>> Currently, the largest volume size for building OVMF images is 4MB. With
>>> the growth of the Linuxboot project, maintainers have had to maintain a
>>> fork containing this patch which allows larger image sizes in order for
>>> Linuxboot developers/users to have enough space to experiment with
>>> and test including their own Linux kernel in the DXE section of OVMF
>>> firmware. Testing using OVMF is valuable since it allows testing in QEMU
>>> and thus does not require any hardware to do so.
>>>
>>> This patch allows specifying '-D FD_SIZE_8MB' or '-D FD_SIZE_16MB' to
>>> the OVMF build script in order to add the ability to build 8MB or 16MB
>>> x86_64 (X64) OVMF images, respectively.
>>>
>>> Signed-off-by: Devon Bautista <dbautista@newmexicoconsortium.org>
>>> ---
>>>   OvmfPkg/OvmfPkgDefines.fdf.inc | 34 ++++++++++++++++++++++++++++++++++
>>>   OvmfPkg/OvmfPkgX64.dsc         | 10 +++++++++-
>>>   OvmfPkg/VarStore.fdf.inc       | 16 ++++++++--------
>>>   3 files changed, 51 insertions(+), 9 deletions(-)
>>>
>> I'm providing minimal feedback here just to get this review off my plate
>> as quickly as possible. Sorry, I'm collapsing under my TODO list.
> PS: please file a tianocore feature request at <https://bugzilla.tianocore.org/>, and please link the current (v1) posting into it (in a new bugzilla comment), with the following URLs:
>
> https://edk2.groups.io/g/devel/message/75666
> https://listman.redhat.com/archives/edk2-devel-archive/2021-May/msg01106.html
> http://mid.mail-archive.com/7bfd4b82fc725302beb37e13c4a89d389c34ec34.1622048433.git.dbautista@newmexicoconsortium.org
>
> Thanks!
> Laszlo
>
Tianocore Feature Request:
https://bugzilla.tianocore.org/show_bug.cgi?id=3420


  parent reply	other threads:[~2021-05-28 20:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 17:08 [PATCH v1] OvmfPkg: Add build options for 8MB and 16MB X64 OVMF images Devon Bautista
2021-05-27 10:12 ` [edk2-devel] " Laszlo Ersek
2021-05-27 10:14   ` Laszlo Ersek
2021-05-27 10:21     ` Laszlo Ersek
2021-05-28 20:49     ` Devon Bautista [this message]
2021-05-28 13:33   ` Brian J. Johnson
2021-06-01 12:20     ` Laszlo Ersek
2021-07-28 19:43   ` Devon Bautista

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29122019-b50a-4104-9b9e-8efd829ecd9d@newmexicoconsortium.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox