From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web12.59314.1629311829649299070 for ; Wed, 18 Aug 2021 11:37:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=yyelgbVg; spf=pass (domain: nuviainc.com, ip: 209.85.214.171, mailfrom: rebecca@nuviainc.com) Received: by mail-pl1-f171.google.com with SMTP id w6so2325593plg.9 for ; Wed, 18 Aug 2021 11:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=oMBsyXNYopoyYhhvKV5qTItsvaBPdxdZ2d5xtA0qBQg=; b=yyelgbVglRCadXhFpQK8X2BI/d0zUmFn+Nn0R7pUeZsEXQmt3w6pXacZrhiH6LueLx pSb5bmQt5jKZ74nw7TxNn0cbbIo9QAiEsDlEyLl16wBRmretQSShn4wKfRPwdrxD8AIa eTYIxstEE8CMbH3aDqrGfsSym7yfuW6vFgUUoq6ph7ZcluF7+tFJMWyeNA0L3CSRnaf9 rmZ7LmWVvx5zW0rjLcmT1ZBZ0Br5cIwUfHC+rJZqQTCnOPxUUEkMQmt+oEJjNMeI2kAN 3J47RiXWEH3xzChYOaZLEbYm7CeqLdHNsFJNoZJh6XJjgd17Ui38I9ZQekHeA40wuP5w dCeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=oMBsyXNYopoyYhhvKV5qTItsvaBPdxdZ2d5xtA0qBQg=; b=KBP5miRTGIwK3MHDQW3JYd0rb89dXs0SHtmhuN1abrKXhyusDl3fxHSduMvNlG3JPX R/Xiu+8/IcI1RnLRH0ZBzA92D8QwQWiCIye2IWM0Ok0DSkngHAlA13LVu/2oB7/1X6ba n5rb73z6JdCjUdeFC0sNt01PwF5+Y4k4hZZM1UDh6TN8sUgPqGGaJN0V8XsyAc893Of3 UNzLhQx09khVxbV3CEVazcr0iwtg0xMmUEiSKZmYFfzW+fHLAvo2dKL1C5/hlQh83QnA 1XIb/77MIvuuGS0KChEXu4/pqyoJZNbN/qf+7MCKcI5tZVAUE63idEoeJkyTaVe++Y6g Hsog== X-Gm-Message-State: AOAM5331XEHBiVzWBZZ8PLMS6qN7R5GKWPAtGK7htF+CG34IQy7+7QGd qT+kIfGTu3CFgA06u04y6r36roe//GDOxJUR9FMp0vyAbzGtscDjPytdkV3fn7Bg57Em8XYWtFl 6efDP6Sw/qpeBogND95hPkmEQ+GJIVM5sP85y/7HkCTz1WeVaAKT8yHtQtRxtUayBKFXmHTqT X-Google-Smtp-Source: ABdhPJyqjr4QKyAAc3Lgt1rVQQ0c9wuCy6dl1GwgiAZxjlXk12MsvyjwqeXh0b7AXESOzZjTg4oZQA== X-Received: by 2002:a17:902:7406:b029:12d:3bc1:3812 with SMTP id g6-20020a1709027406b029012d3bc13812mr8325046pll.67.1629311828889; Wed, 18 Aug 2021 11:37:08 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id 10sm533022pjc.41.2021.08.18.11.37.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 11:37:08 -0700 (PDT) Subject: Re: [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019 To: Michael D Kinney , devel@edk2.groups.io References: <20210818054206.1223-1-michael.d.kinney@intel.com> From: "Rebecca Cran" Message-ID: <293d1839-f444-a00a-40a2-7a64ced2b6d0@nuviainc.com> Date: Wed, 18 Aug 2021 12:37:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210818054206.1223-1-michael.d.kinney@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US For patches 1,2,4,7-9: Reviewed-by: Rebecca Cran -- Rebecca Cran On 8/17/21 11:41 PM, Michael D Kinney wrote: > Update AppPkg and StdLib* to build using latest edk2/master and > support VS2017 and VS2019. > > Most of the changes are related to warning levels, missing symbols and > duplicate symbols that were uncovered by the use of the /WHOLEARCHIVE > flag. > > Cc: Rebecca Cran > Signed-off-by: Michael D Kinney > > Michael D Kinney (9): > StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS > StdLib: Add MdeLibs.dsc.inc to StdLib.dsc > StdLib: Remove SocketDxe from build > StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function. > StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF > StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS > AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc > AppPkg/Applications/Python: Enable HAVE_COPYSIGN define > AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes > > AppPkg/AppPkg.dsc | 2 ++ > AppPkg/Applications/Python/Ia32/pyconfig.h | 2 +- > AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h | 2 +- > AppPkg/Applications/Python/Python-2.7.10/Python2710.inf | 7 ++----- > AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h | 2 +- > AppPkg/Applications/Python/X64/pyconfig.h | 3 +-- > StdLib/BsdSocketLib/BsdSocketLib.inf | 4 ++++ > StdLib/LibC/gdtoa/gdtoa.inf | 1 - > StdLib/StdLib.dsc | 2 ++ > StdLib/StdLib.inc | 4 +++- > 10 files changed, 17 insertions(+), 12 deletions(-) >