public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Graeme Gregory <graeme.gregory@linaro.org>,
	Tanmay Jagdale <tanmay.jagdale@linaro.org>
Cc: leif@nuviainc.com, devel@edk2.groups.io, rad@semihalf.com
Subject: Re: Silicon/SbsaQemu: Fix NOR flash RegionBaseAddress
Date: Wed, 17 Jun 2020 10:41:16 +0200	[thread overview]
Message-ID: <2945ac97-5fd0-c3a8-5e4d-e81fe7242542@arm.com> (raw)
In-Reply-To: <20200617073911.GD7491@xora-acepc>

On 6/17/20 9:39 AM, Graeme Gregory wrote:
> On Wed, Jun 17, 2020 at 12:59:13AM +0530, Tanmay Jagdale wrote:
>> The EFI_FIMRWARE_VOLUME_HEADER is present at an offset in the
>> NOR flash of Sbsa QEMU model. Use the right RegionBaseAddress
>> so that the EFI firmware volume header can be found correctly.
>>
>> Signed-off-by: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> 
> This fixes the problem for me, I have tested setting variables from
> efi shell and from debian guest OS and they persist correctly now.
> 
> Tested-by: Graeme Gregory <graeme.gregory@linaro.org>
> 

Pushed as 8b2c8fcaa90b..5f13ce8a65f2

Thanks,

      reply	other threads:[~2020-06-17  8:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 19:29 Silicon/SbsaQemu: Fix NOR flash RegionBaseAddress Tanmay Jagdale
2020-06-17  7:39 ` Graeme Gregory
2020-06-17  8:41   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2945ac97-5fd0-c3a8-5e4d-e81fe7242542@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox