From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.3247.1592383285709495821 for ; Wed, 17 Jun 2020 01:41:25 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E422C0A; Wed, 17 Jun 2020 01:41:24 -0700 (PDT) Received: from [192.168.1.69] (unknown [10.37.8.36]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 841B93F6CF; Wed, 17 Jun 2020 01:41:21 -0700 (PDT) Subject: Re: Silicon/SbsaQemu: Fix NOR flash RegionBaseAddress To: Graeme Gregory , Tanmay Jagdale Cc: leif@nuviainc.com, devel@edk2.groups.io, rad@semihalf.com References: <20200616192913.56882-1-tanmay.jagdale@linaro.org> <20200617073911.GD7491@xora-acepc> From: "Ard Biesheuvel" Message-ID: <2945ac97-5fd0-c3a8-5e4d-e81fe7242542@arm.com> Date: Wed, 17 Jun 2020 10:41:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200617073911.GD7491@xora-acepc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/17/20 9:39 AM, Graeme Gregory wrote: > On Wed, Jun 17, 2020 at 12:59:13AM +0530, Tanmay Jagdale wrote: >> The EFI_FIMRWARE_VOLUME_HEADER is present at an offset in the >> NOR flash of Sbsa QEMU model. Use the right RegionBaseAddress >> so that the EFI firmware volume header can be found correctly. >> >> Signed-off-by: Tanmay Jagdale > > This fixes the problem for me, I have tested setting variables from > efi shell and from debian guest OS and they persist correctly now. > > Tested-by: Graeme Gregory > Pushed as 8b2c8fcaa90b..5f13ce8a65f2 Thanks,