From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.12511.1582887086371477315 for ; Fri, 28 Feb 2020 02:51:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=YnxcBvcR; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.66, mailfrom: pete@akeo.ie) Received: by mail-wm1-f66.google.com with SMTP id d138so1083618wmd.5 for ; Fri, 28 Feb 2020 02:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=30qL3lKpUT7zbeCTM1P1VcceNyKBfTEKvegsbMSdHB0=; b=YnxcBvcR8FoD7StaMQ+/xXRqAqnDmLgmmJRd4LqbyhTD6ajw+f+fVs6WNIjatE9JCA S3NlW4K4Leuqcj6fm/e/LLmf5t13lPesuRZAcTQzcnwuaB4YqAI/xW+BD3nc1lCPpySP 1TFgKFIQFjH3wrfSs7bHdZYPzqYxIgSRDN2NZ1sJqKnf1DUobkYFbGJP+aKu+3aBAa+O dnpO+UwRBt4SMYUgvUxq+3lhA06QbAH0dagG+dnuttstKm9Vm0iU5cvdYsXsTNGTSqP3 L7ibXKh+xCM8rvA+n/M716ZEAg9AwYDcN58JAkK9W+C/i+9OEI/bySQ+WqhiY335F+Zm 78ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=30qL3lKpUT7zbeCTM1P1VcceNyKBfTEKvegsbMSdHB0=; b=QFgrFYTK4dupfim8IcbagJMRgoIRinMLuVhMoJNbXTTGvxv5hYpuxdZNZTh5RTR0Dt oU1JnXKOUx/yZ0eU2XFBX1dY+xU0hNsPgNih6ZmWzgIh6CrPsvQttym6YumULH5ghv4U GcEfkZPOm28aI2oYkejBJyrKT07lVxZpyVKK0Wjgv5mnrfmBn9kgx4+eLTas0d9DcvCX NfX0ALo2X+qKG3QtBaYR3oyEgLdDFbKV5vC43Z6kYWNra83BmmO+VfGMrVbZWFUjcQQ+ YN3SZjGOqBptQu/9clvPQA1dhRzsq3hSd7YgAWzt+f5xphHmwQO79Ks5xjFVUr+bPLus VuMw== X-Gm-Message-State: APjAAAXzyHoQN3cKe8QHyYM+FbYJIwBHWFHg7yad2b5KilsBnfLxZyo2 07UED/DLHJ2jYZwqExP4ajfD8g== X-Google-Smtp-Source: APXvYqwdrrvncmn9QT45W49NRJrXMVQAWq39ddb41GlUqgBHMLkkiGdPXuyXfYfqHlpT+7MNfWASHA== X-Received: by 2002:a7b:cb93:: with SMTP id m19mr4491764wmi.128.1582887084983; Fri, 28 Feb 2020 02:51:24 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.56.244]) by smtp.googlemail.com with ESMTPSA id d9sm11959743wrx.94.2020.02.28.02.51.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 02:51:24 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up To: Ard Biesheuvel Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200228103855.11352-1-pete@akeo.ie> <20200228103855.11352-5-pete@akeo.ie> From: "Pete Batard" Message-ID: <295ffa3b-aec9-f21a-0017-ae3b8949f2a9@akeo.ie> Date: Fri, 28 Feb 2020 10:51:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ard, On 2020.02.28 10:45, Ard Biesheuvel wrote: > On Fri, 28 Feb 2020 at 11:39, Pete Batard wrote: >> >> Remove unneeded extra parenthesis on PCD, which can cause problems >> when used with ACPI ASL macros and add an [Includes] section to the >> .inf, so that the Genet.h header can be referenced where required. >> >> Signed-off-by: Pete Batard >> --- >> Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h | 3 ++- >> Silicon/Broadcom/Drivers/Net/BcmNet.dec | 3 +++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h >> index 4a3827c0e0d1..f56fb2977422 100644 >> --- a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h >> +++ b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h >> @@ -11,7 +11,8 @@ >> >> #include >> >> -#define GENET_BASE_ADDRESS (FixedPcdGet64 (PcdBcmGenetRegistersAddress)) >> +#define GENET_BASE_ADDRESS FixedPcdGet64 (PcdBcmGenetRegistersAddress) >> +#define GENET_LENGTH 0x00010000 >> >> #define GENET_SYS_RBUF_FLUSH_CTRL 0x0008 >> #define GENET_UMAC_MAC0 0x080c >> diff --git a/Silicon/Broadcom/Drivers/Net/BcmNet.dec b/Silicon/Broadcom/Drivers/Net/BcmNet.dec >> index 2a8688cb09a7..483b033af51c 100644 >> --- a/Silicon/Broadcom/Drivers/Net/BcmNet.dec >> +++ b/Silicon/Broadcom/Drivers/Net/BcmNet.dec >> @@ -12,6 +12,9 @@ [Defines] >> PACKAGE_GUID = 34E19823-D23A-41AB-9C09-ED1225B32DFF >> PACKAGE_VERSION = 1.0 >> >> +[Includes] >> + . >> + > > This looks fishy. Won't this cause *every* module that incorporates > this .dec to add . to its include path? Yeah, I don't like it either. I kind of expected you guys to comment on it, so that we can discuss what you think the better approach should be. Do you think it'd make sense to create a Drivers/Include/ section in Silicon/Broadcom/ and move the header there? And if we do that, do you think the header should go to something like Include/Net or just reside at the top level of Include/? What would be your preferred approach? Regards, /Pete > >> [Guids] >> gBcmNetTokenSpaceGuid = {0x12b97d70, 0x9149, 0x4c2f, {0x82, 0xd5, 0xad, 0xa9, 0x1e, 0x92, 0x75, 0xa1}} >> >> -- >> 2.21.0.windows.1 >>