From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 45EB5211B63E9 for ; Wed, 9 Jan 2019 23:29:04 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 23:29:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,460,1539673200"; d="scan'208";a="124904982" Received: from shzintpr03.sh.intel.com (HELO [10.7.209.21]) ([10.239.4.100]) by orsmga002.jf.intel.com with ESMTP; 09 Jan 2019 23:29:00 -0800 To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Hao Wu , Liming Gao , Michael D Kinney , Laszlo Ersek , star.zeng@intel.com References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> <20190103182825.32231-8-ard.biesheuvel@linaro.org> From: "Zeng, Star" Message-ID: <296d89b0-e877-65c0-b210-0619e8fd89be@intel.com> Date: Thu, 10 Jan 2019 15:28:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190103182825.32231-8-ard.biesheuvel@linaro.org> Subject: Re: [PATCH 6/6] MdeModulePkg/VariableRuntimeDxe: implement standalone MM version X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 07:29:04 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, Some minor feedback added below. With them handled, Reviewed-by: Sta Zeng . On 2019/1/4 2:28, Ard Biesheuvel wrote: > Reuse most of the existing code to implement a variable runtime > driver that will be able to execute in the context of standalone > MM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c | 69 ++++++++++ > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf | 135 ++++++++++++++++++++ > 2 files changed, 204 insertions(+) Please add it into MdeModulePkg.dsc for package build verification. > > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > new file mode 100644 > index 000000000000..fbc99467c057 > --- /dev/null > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > @@ -0,0 +1,69 @@ > +/** @file > + > + Parts of the SMM/MM implementation that are specific to standalone MM > + > +Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018, Linaro, Ltd. All rights reserved.
> +This program and the accompanying materials > +are licensed and made available under the terms and conditions of the BSD License > +which accompanies this distribution. The full text of the license may be found at > +http://opensource.org/licenses/bsd-license.php > + > +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > + > +#include "Variable.h" > + > +BOOLEAN > +VariableSmmIsBufferOutsideSmmValid ( > + IN EFI_PHYSICAL_ADDRESS Buffer, > + IN UINT64 Length > + ) > +{ > + return TRUE; > +} Please add function comment header for it. > + > +/** > + Notify the system that the SMM variable driver is ready > +**/ > +VOID > +VariableNotifySmmReady ( > + VOID > + ) > +{ > +} > + > +/** > + Notify the system that the SMM variable write driver is ready > +**/ > +VOID > +VariableNotifySmmWriteReady ( > + VOID > + ) > +{ > +} > + > +EFI_STATUS > +EFIAPI > +VariableServiceInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > + ) > +{ > + return MmVariableServiceInitialize (); > +} Please add function comment header for it. > + > +/** > + Whether the TCG or TCG2 protocols are installed in the UEFI protocol database. > + This information is used by the MorLock code to infer whether an existing > + MOR variable is legitimate or not. Add a line for return description? Thanks, Star > +**/ > +BOOLEAN > +VariableHaveTcgProtocols ( > + VOID > + ) > +{ > + return FALSE; > +} > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > new file mode 100644 > index 000000000000..54d647af914c > --- /dev/null > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > @@ -0,0 +1,135 @@ > +## @file > +# Provides SMM variable service. > +# > +# This module installs SMM variable protocol into SMM protocol database, > +# which can be used by SMM driver, and installs SMM variable protocol > +# into BS protocol database, which can be used to notify the SMM Runtime > +# Dxe driver that the SMM variable service is ready. > +# This module should be used with SMM Runtime DXE module together. The > +# SMM Runtime DXE module would install variable arch protocol and variable > +# write arch protocol based on SMM variable module. > +# > +# Caution: This module requires additional review when modified. > +# This driver will have external input - variable data and communicate buffer in SMM mode. > +# This external input must be validated carefully to avoid security issues such as > +# buffer overflow or integer overflow. > +# The whole SMM authentication variable design relies on the integrity of flash part and SMM. > +# which is assumed to be protected by platform. All variable code and metadata in flash/SMM Memory > +# may not be modified without authorization. If platform fails to protect these resources, > +# the authentication service provided in this driver will be broken, and the behavior is undefined. > +# > +# Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
> +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = VariableStandaloneMm > + FILE_GUID = 7ee2c0c1-c21a-4113-a53a-66824a95696f > + MODULE_TYPE = MM_STANDALONE > + VERSION_STRING = 1.0 > + PI_SPECIFICATION_VERSION = 0x00010032 > + ENTRY_POINT = VariableServiceInitialize > + > +# > +# The following information is for reference only and not required by the build tools. > +# > +# VALID_ARCHITECTURES = AARCH64 > +# > + > + > +[Sources] > + Reclaim.c > + Variable.c > + VariableSmm.c > + VariableStandaloneMm.c > + VarCheck.c > + Variable.h > + PrivilegePolymorphic.h > + VariableExLib.c > + TcgMorLockSmm.c > + SpeculationBarrierSmm.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + StandaloneMmPkg/StandaloneMmPkg.dec > + > +[LibraryClasses] > + AuthVariableLib > + BaseLib > + BaseMemoryLib > + DebugLib > + HobLib > + MemoryAllocationLib > + MmServicesTableLib > + StandaloneMmDriverEntryPoint > + SynchronizationLib > + VarCheckLib > + > +[Protocols] > + gEfiSmmFirmwareVolumeBlockProtocolGuid ## CONSUMES > + ## CONSUMES > + ## NOTIFY > + gEfiSmmFaultTolerantWriteProtocolGuid > + ## PRODUCES > + ## UNDEFINED # SmiHandlerRegister > + gEfiSmmVariableProtocolGuid > + gEfiMmEndOfDxeProtocolGuid ## NOTIFY > + gEdkiiSmmVarCheckProtocolGuid ## PRODUCES > + > +[Guids] > + ## SOMETIMES_CONSUMES ## GUID # Signature of Variable store header > + ## SOMETIMES_PRODUCES ## GUID # Signature of Variable store header > + ## SOMETIMES_CONSUMES ## HOB > + ## SOMETIMES_PRODUCES ## SystemTable > + gEfiAuthenticatedVariableGuid > + > + ## SOMETIMES_CONSUMES ## GUID # Signature of Variable store header > + ## SOMETIMES_PRODUCES ## GUID # Signature of Variable store header > + ## SOMETIMES_CONSUMES ## HOB > + ## SOMETIMES_PRODUCES ## SystemTable > + gEfiVariableGuid > + > + ## SOMETIMES_CONSUMES ## Variable:L"PlatformLang" > + ## SOMETIMES_PRODUCES ## Variable:L"PlatformLang" > + ## SOMETIMES_CONSUMES ## Variable:L"Lang" > + ## SOMETIMES_PRODUCES ## Variable:L"Lang" > + gEfiGlobalVariableGuid > + > + gEfiMemoryOverwriteControlDataGuid ## SOMETIMES_CONSUMES ## Variable:L"MemoryOverwriteRequestControl" > + gEfiMemoryOverwriteRequestControlLockGuid ## SOMETIMES_PRODUCES ## Variable:L"MemoryOverwriteRequestControlLock" > + > + gEfiSystemNvDataFvGuid ## CONSUMES ## GUID > + gEdkiiFaultTolerantWriteGuid ## SOMETIMES_CONSUMES ## HOB > + > + ## SOMETIMES_CONSUMES ## Variable:L"VarErrorFlag" > + ## SOMETIMES_PRODUCES ## Variable:L"VarErrorFlag" > + gEdkiiVarErrorFlagGuid > + > +[FixedPcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase ## SOMETIMES_CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxUserNvVariableSpaceSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdBoottimeReservedNvVariableSpaceSize ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe ## CONSUMES > + > +[FeaturePcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdVariableCollectStatistics ## CONSUMES # statistic the information of variable. > + gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultLangDeprecate ## CONSUMES # Auto update PlatformLang/Lang > + > +[Depex] > + TRUE >