From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly To: Ard Biesheuvel ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Fremont, California, US (217.140.99.251) X-Originating-Platform: Windows Firefox 77 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 15 Jun 2020 06:59:58 -0700 References: <20200610081740.54581-6-ard.biesheuvel@arm.com> In-Reply-To: <20200610081740.54581-6-ard.biesheuvel@arm.com> Message-ID: <29709.1592229598095627048@groups.io> Content-Type: multipart/alternative; boundary="oJhmva8cbQI3u9z0Ppeh" --oJhmva8cbQI3u9z0Ppeh Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Apologies for top replying. I am not sure if it is my setup where I see add= itional characters (e.g. =3D0D at the end of each line) which appear to con= fuse my email client. > UpdateMmFoundationPeCoffPermissions (=3D0D > IN CONST PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext,=3D0D > + IN EFI_PHYSICAL_ADDRESS ImageBase,=3D0D Can the function documentation for UpdateMmFoundationPeCoffPermissions() a= nd GetStandaloneMmCorePeCoffSections() be updated to reflect the additional= parameter ImageBase, please? On Wed, Jun 10, 2020 at 01:17 AM, Ard Biesheuvel wrote: >=20 > + *ImageBase =3D3D ImageContext->ImageAddress;=3D0D I think the '*ImageBase =3D ImageContext->ImageAddress;' statement can be = moved inside the if condition. With these changes. Reviewed-by: Sami Mujawar Sami Mujawar --oJhmva8cbQI3u9z0Ppeh Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Apologies for top replying. I am not sure if it is my set= up where I see additional characters (e.g. =3D0D at the end of each line) w= hich appear to confuse my email client.

> UpdateMmFoundationPeCoffPermissions (=3D0D
> IN CONST PE_= COFF_LOADER_IMAGE_CONTEXT *ImageContext,=3D0D
> + IN EFI_PHYSICAL_AD= DRESS ImageBase,=3D0D
Can the function documentation for UpdateMmFounda= tionPeCoffPermissions() and GetStandaloneMmCorePeCoffSections() be updated = to reflect the additional parameter ImageBase, please?

On Wed, Jun= 10, 2020 at 01:17 AM, Ard Biesheuvel wrote:

+ *ImageBase =3D3D ImageContext->ImageAddress;=3D0D I think the '*ImageBase =3D ImageContext->ImageAddress;' statem= ent can be moved inside the if condition.
With these changes.

= Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Sami Mujaw= ar --oJhmva8cbQI3u9z0Ppeh--