From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0hdIEJhc2VUb29sczogQ2F0Y2ggdGhlIGV4Y2VwdGlvbiBpbiBidWlsZC5weS4=?= To: fengyunhua ,devel@edk2.groups.io From: "Mingyue Liang" X-Originating-Location: CN (192.102.204.53) X-Originating-Platform: Windows Chrome 97 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 14 Feb 2022 22:01:07 -0800 References: <000001d6b311$36970090$a3c501b0$@byosoft.com.cn> In-Reply-To: <000001d6b311$36970090$a3c501b0$@byosoft.com.cn> Message-ID: <29793.1644904867863463704@groups.io> Content-Type: multipart/alternative; boundary="5PCVsmHozEJ2oR5uqb1F" --5PCVsmHozEJ2oR5uqb1F Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi fengyunhua: This patch is used to report error messages. For the contents of the error messages you mentioned, please submit another= bugzilla. On Thu, Nov 5, 2020 at 09:15 AM, fengyunhua wrote: >=20 > I tried this patch, modified OvmfPkgIa32.fdf > INF OvmfPkg/Sec/SecMain.inf > =3D=3D=3D> > INM OvmfPkg/Sec/SecMain.inf >=20 > the error message as below: >=20 > build.py... > c:\work\edk2\OvmfPkg\OvmfPkgIa32.fdf(118): error 3000: Invalid > syntax/format > expected [FD.] near line 110, column 22: TRUE >=20 > on my opinion, "expected [FD.]" is not correct >=20 > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66996+5049190+8953120@groups.io > =E4=BB=A3=E8=A1=A8 mliang2= x > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=884=E6=97=A5 = 15:53 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Mingyue Liang ; Bob Feng > ; Liming Gao ; Yuwei Chen > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH] BaseTools: Catch the exception i= n build.py. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2988 >=20 > In FDF file, if INF key word is wrongly written as INT, > build tool will report the execption. Build tool should > report the error message. >=20 > build.py In order to capture and handle the exception > of fdfparser, the user-defined exception class should > be imported. >=20 > Signed-off-by: Mingyue Liang > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > BaseTools/Source/Python/build/build.py | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/BaseTools/Source/Python/build/build.py > b/BaseTools/Source/Python/build/build.py > index 1ab1e60a64..49165ea355 100755 > --- a/BaseTools/Source/Python/build/build.py > +++ b/BaseTools/Source/Python/build/build.py > @@ -62,6 +62,7 @@ from AutoGen.ModuleAutoGenHelper import WorkSpaceInfo, > PlatformInfo > from GenFds.FdfParser import FdfParser > from AutoGen.IncludesAutoGen import IncludesAutoGen > from GenFds.GenFds import resetFdsGlobalVariable > +from GenFds.FdfParser import Warning >=20 > ## standard targets of build command > gSupportedTarget =3D ['all', 'genc', 'genmake', 'modules', 'libraries', > 'fds', 'clean', 'cleanall', 'cleanlib', 'run'] > -- > 2.28.0.windows.1 --5PCVsmHozEJ2oR5uqb1F Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi fengyunhua:
      This patch is used to report error= messages.
      For the contents of the error message= s you mentioned, please submit another bugzilla.

On Thu, Nov 5, = 2020 at 09:15 AM, fengyunhua wrote:
I tried this patch, modified OvmfPkgIa32.fdf
INF OvmfPkg/S= ec/SecMain.inf
=3D=3D=3D>
INM OvmfPkg/Sec/SecMain.inf
the error message as below:

build.py...
c:\work\edk2\Ovm= fPkg\OvmfPkgIa32.fdf(118): error 3000: Invalid syntax/format
expected = [FD.] near line 110, column 22: TRUE

on my opinion, "expected [F= D.]" is not correct

-----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6---= --
=E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66996+5049190+8953120@gro= ups.io
<bounce+27952+66996+5049190+8953120@groups.io> =E4=BB=A3= =E8=A1=A8 mliang2x
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B4= 11=E6=9C=884=E6=97=A5 15:53
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.gr= oups.io
=E6=8A=84=E9=80=81: Mingyue Liang <mingyuex.liang@intel.com= >; Bob Feng
<bob.c.feng@intel.com>; Liming Gao <gaoliming@= byosoft.com.cn>; Yuwei Chen
<yuwei.chen@intel.com>
=E4= =B8=BB=E9=A2=98: [edk2-devel] [PATCH] BaseTools: Catch the exception in bui= ld.py.

REF: https://bugzilla.tianocore= .org/show_bug.cgi?id=3D2988

In FDF file, if INF key word is = wrongly written as INT,
build tool will report the execption. Build to= ol should
report the error message.

build.py In order to ca= pture and handle the exception
of fdfparser, the user-defined exceptio= n class should
be imported.

Signed-off-by: Mingyue Liang &l= t;mingyuex.liang@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com&g= t;
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen= <yuwei.chen@intel.com>
---
BaseTools/Source/Python/build/b= uild.py | 1 +
1 file changed, 1 insertion(+)

diff --git a/B= aseTools/Source/Python/build/build.py
b/BaseTools/Source/Python/build/= build.py
index 1ab1e60a64..49165ea355 100755
--- a/BaseTools/Sour= ce/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py<= br />@@ -62,6 +62,7 @@ from AutoGen.ModuleAutoGenHelper import WorkSpaceInf= o,
PlatformInfo
from GenFds.FdfParser import FdfParser
from = AutoGen.IncludesAutoGen import IncludesAutoGen
from GenFds.GenFds impo= rt resetFdsGlobalVariable
+from GenFds.FdfParser import Warning
<= br />## standard targets of build command
gSupportedTarget =3D ['all',= 'genc', 'genmake', 'modules', 'libraries',
'fds', 'clean', 'cleanall'= , 'cleanlib', 'run']
--
2.28.0.windows.1
--5PCVsmHozEJ2oR5uqb1F--