From: "PierreGondois" <pierre.gondois@arm.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
Yi Li <yi1.li@intel.com>, Xiaoyu Lu <xiaoyu1.lu@intel.com>,
Guomin Jiang <guomin.jiang@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 6/7] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks
Date: Wed, 8 Nov 2023 15:40:11 +0100 [thread overview]
Message-ID: <2979cd0c-0dc3-4cc3-a665-2201cb0710dc@arm.com> (raw)
In-Reply-To: <v2rrh67syzkmimrox3rbn6za5p4z47mwygusbk24ya256ztoze@heodvnj6ti63>
Hello Gerd,
On 11/7/23 10:21, Gerd Hoffmann wrote:
>> [Sources.AARCH64]
>> + OpensslStub/AArch64Cap.c
>> # Autogenerated files list starts here
>> $(OPENSSL_PATH)/crypto/aes/aes_cbc.c
>> $(OPENSSL_PATH)/crypto/aes/aes_cfb.c
>> @@ -1598,7 +1599,7 @@ [Sources.AARCH64]
>> $(OPENSSL_PATH)/crypto/kdf/kdf_err.c
>> $(OPENSSL_PATH)/crypto/lhash/lh_stats.c
>> $(OPENSSL_PATH)/crypto/lhash/lhash.c
>> - $(OPENSSL_PATH)/crypto/armcap.c
>> +# $(OPENSSL_PATH)/crypto/armcap.c
>
> Manually changing autogenerated file lists isn't going to work very
> well. The next time someone runs configure.�py the changes are wiped
> out ...
>
> Please update the sources_filter_fn function in the configure.py script
> instead.
Ok yes, I will do that,
Regards,
Pierre
>
> take care,
> Gerd
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110916): https://edk2.groups.io/g/devel/message/110916
Mute This Topic: https://groups.io/mt/102342402/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-08 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 13:54 [edk2-devel] [PATCH v1 0/7] CryptoPkg: Enable Openssl native instruction support for AARCH64 PierreGondois
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 1/7] MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg() PierreGondois
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 2/7] MdePkg/BaseLib: AARCH64: Add ArmReadIdAA64Isar0Reg() PierreGondois
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 3/7] MdePkg/BaseRngLib: Prefer ArmReadIdAA64Isar0Reg() over ArmReadIdIsar0() PierreGondois
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 4/7] CryptoPkg/OpensslLib: Add native instruction support for AARCH64 PierreGondois
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 5/7] CryptoPkg/OpensslLib: Generate files for AARCH64 native support PierreGondois
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 6/7] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks PierreGondois
2023-11-07 9:21 ` Gerd Hoffmann
2023-11-08 14:40 ` PierreGondois [this message]
2023-11-02 13:54 ` [edk2-devel] [PATCH v1 7/7] CryptoPkg: Enable Openssl Accel builds for AARCH64 PierreGondois
2023-11-07 2:38 ` [edk2-devel] [PATCH v1 0/7] CryptoPkg: Enable Openssl native instruction support " Li, Yi
2023-11-07 2:57 ` Yao, Jiewen
2023-11-08 14:39 ` PierreGondois
2023-11-08 15:03 ` Ard Biesheuvel
2023-11-08 16:19 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2979cd0c-0dc3-4cc3-a665-2201cb0710dc@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox