From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Minh Nguyen <minhnguyen1@os.amperecomputing.com>, devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
khanh.pham@os.amperecomputing.com, nhi@os.amperecomputing.com,
tinhnguyen@os.amperecomputing.com, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
Date: Tue, 16 May 2023 09:28:10 +0100 [thread overview]
Message-ID: <29942be3-278d-e525-9f9d-0862e08bf7ad@arm.com> (raw)
In-Reply-To: <20230516070812.3606476-3-minhnguyen1@os.amperecomputing.com>
Hi Minh,
Thank you for this patch.
This fix looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 16/05/2023 08:08 am, Minh Nguyen wrote:
> This helps to remove redundant assign for SmbiosHandle.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> ---
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> index 7250da02b3ac..313129460d9c 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> @@ -213,8 +213,6 @@ SmbiosMiscGetLinkTypeHandle (
> return;
> }
>
> - SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
> -
> for (Index = 0; Index < (*HandleCount); Index++) {
> Status = mSmbiosMiscSmbios->GetNext (
> mSmbiosMiscSmbios,
next prev parent reply other threads:[~2023-05-16 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 7:08 [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Minh Nguyen
2023-05-16 7:08 ` [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records Minh Nguyen
2023-05-16 8:27 ` Sami Mujawar
2023-05-16 7:08 ` [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle Minh Nguyen
2023-05-16 8:28 ` Sami Mujawar [this message]
2023-05-23 9:23 ` [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Nhi Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29942be3-278d-e525-9f9d-0862e08bf7ad@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox