From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.72]) by mx.groups.io with SMTP id smtpd.web11.16902.1684225706421136944 for ; Tue, 16 May 2023 01:28:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=UZ5cQOC1; spf=pass (domain: arm.com, ip: 40.107.21.72, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uR7Z7yTBFZQWG8D+3ECT2SLiGKF2cPT60IU26N+scZk=; b=UZ5cQOC1XaTcCjKi/MWTKvIUzZSuEFjRnf9K6fRMbuIMthcVVyeMOI+eDsmG5FC1zetlusNp+emVLo6Pt1a9GUWknWiJtHsL2/bb2pzRxiATyridFyUxf+Rmbvfu47ayUSRHHpWrO5tF7v6vuVz0M9yLD3BVf3y3AJ4nejKLGpA= Received: from AS4P190CA0037.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d1::18) by AS2PR08MB8975.eurprd08.prod.outlook.com (2603:10a6:20b:5fb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May 2023 08:28:23 +0000 Received: from AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d1:cafe::2c) by AS4P190CA0037.outlook.office365.com (2603:10a6:20b:5d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend Transport; Tue, 16 May 2023 08:28:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT016.mail.protection.outlook.com (100.127.140.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 08:28:22 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Tue, 16 May 2023 08:28:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ce408d402cbbd956 X-CR-MTA-TID: 64aa7808 Received: from 42c2a572cbb3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22CDC0DE-EB46-4DC0-9CED-2ED7128BB9D1.1; Tue, 16 May 2023 08:28:16 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 42c2a572cbb3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 May 2023 08:28:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaiHaYjOU0J+RdmEHnPPSFikFkBcsEduGM0ovS4XmZb1sorA4HRxJlI8z+yW5Bk+pRh5cOZnk2pGtCRwimJTSXaCOWu9yDSoufqyanOu6hWSB7//zXjsjBsYnIQTGgS6/ZcQPfFxLHBAEWf+njAZ2Xd+divFOXPEBk7oXlx75UpJWA6aDgcbYE89KGMcxQwu5760tGyi++GIFuKETUC9rl4dcrw7A20Ikhm9YzNmx+uRcKVIzDcI701CF6Y0worlTqDM3ZJq0EzxvWObj88tq5j8Spivwwpgs4ylJkpu92LKCyQ4ctj1NVH1Oe3p+JI5sQR+/lGaSzWFQXfLZBAJZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uR7Z7yTBFZQWG8D+3ECT2SLiGKF2cPT60IU26N+scZk=; b=WsIr64zqeEaBpEiVgdb0blEmc/EleWkMIyL3aH8egHX08WdPc1j9hcETEW+ly74TIOtmEM6nXLVwE+M/Tfk4VXHlDcm/BMAKfQq3+anIZ8V6ld0zYwPgnXP5UkSSlEHIoTgeR24Trph71x5pNom7wloRWConFGMIV94QDAENucUzGjAmKwIi6SAVqkiMfOm1y0QymnY3iHWzIp5KiCh2CruHnxxPiT0whBZGViqp2fMo+APayZymj6Uji5fYlFj1ZaDBRU8FkQ2YjIyAA17w1BXmAR96ENcPb4oP5dDDfpwopjnP9xdNKL530+soolOuCBqydxHzPzxygUTycXeoYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uR7Z7yTBFZQWG8D+3ECT2SLiGKF2cPT60IU26N+scZk=; b=UZ5cQOC1XaTcCjKi/MWTKvIUzZSuEFjRnf9K6fRMbuIMthcVVyeMOI+eDsmG5FC1zetlusNp+emVLo6Pt1a9GUWknWiJtHsL2/bb2pzRxiATyridFyUxf+Rmbvfu47ayUSRHHpWrO5tF7v6vuVz0M9yLD3BVf3y3AJ4nejKLGpA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GV2PR08MB9349.eurprd08.prod.outlook.com (2603:10a6:150:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May 2023 08:28:13 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%6]) with mapi id 15.20.6387.032; Tue, 16 May 2023 08:28:13 +0000 Message-ID: <29942be3-278d-e525-9f9d-0862e08bf7ad@arm.com> Date: Tue, 16 May 2023 09:28:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle To: Minh Nguyen , devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, khanh.pham@os.amperecomputing.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, "nd@arm.com" References: <20230516070812.3606476-1-minhnguyen1@os.amperecomputing.com> <20230516070812.3606476-3-minhnguyen1@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20230516070812.3606476-3-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: LO4P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GV2PR08MB9349:EE_|AM7EUR03FT016:EE_|AS2PR08MB8975:EE_ X-MS-Office365-Filtering-Correlation-Id: c597b16d-db62-4369-d1a7-08db55e78325 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CYmeD4BGECMgWfG8DUVBxoO91vVD9m8up9BFGmbhXj3svcx+OuqaPRgGXtwFZ5AYAr6FrG5rArsg66R0Cl6Y0UTP40hnZOfuZLBqr3f8zDvtJpgjJ6g2q0pHbDTWcTTEwfUX0/viVlAEBZDWYvNYcRyUxWLONbe+ZMWHDF5zweb27VhVhxNal+m1c2aYe/4s5ScwFeN+3201X57jkz6lKynDSA795cdBJQniG1dNvdNNZDDzUjy1Wfgf0eFX0cwkQ+dXXL8LbZYOJEcYGRGeFNDxZOKrwkM/IShQsxGpLV8o31dxpAF8SgNsEtIu5wvQiysiCK27uXqTlkHttLxlz0HT/qw0X+FrkEbhXbrk6BcLmADTsN2joEon6qCvHHU0t/pwKSMCp3/8oB1OASpwoUxzqLECSVT3Pn4jqkOiI0btVC0CUakUV0kobRynGCsuDM9zEJ5lKaPoxqlqeQCglZD+rYyXrLIfmW0zLbarJRISeSdTxou044hrjaXkjnKod9OKVkG5NsIEj1ujRNz7CEDEX3oXi0wX2FUVYN/ONJ/y1eUcI3O8+oHJU+chsybi2HfZD9w67myCgoHspUtPDI4H7PcPn1NRtapc5PnfDh5nY1U5ogp0S+QBBAvuPaaoe6QIGXNszH0Ylk2ANdWCkg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199021)(6486002)(53546011)(83380400001)(36756003)(26005)(186003)(6506007)(2616005)(38100700002)(31696002)(86362001)(6512007)(44832011)(8936002)(8676002)(5660300002)(66556008)(41300700001)(66476007)(66946007)(4326008)(316002)(2906002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9349 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1069827b-b60b-4c70-7bc8-08db55e77d8a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yp1aKdwG6ENUlgUvqRDFvknipKQEhpLPYgX18D8UGL8gb4RuRSLOcV50+rXeV5qk0zcc4gecNr02XrJ1pyjGUAxctH2ibnlXRVk5ci4VNsvC7pbwD+PRPLmtqlHjUVV4eduBGTEiS0sHqHlwAemI5YGolHMNAxGuIx/L/WVyhwgCAJqDDxAaZqQxD0eKKvcILy3tmXuGw+8iSa08u9T61+oZ3c+iMJVaH5hXtOXqEJbWgy9C7VDqJPRsdxhcAjokhPn60RaV+DIxrSLwqHVCc3x7dL085Dy3v9AziOthtnv/2Z0I9n92FcNu1iW/E566YZvhD3oEGQ6RWy1Ojjd7qGv/EaCOXKITh5ugKU9kenvQ8pVUxl9g7/VNlagb6Sw5d6rv+XW7X/7CVNPNhVzWHKckWa9ckijVCB+j/ix9I6G6RHV1Zogm9PH3vOJtpdINL6VlGVvGPIMjB/cYvKX3FyBRthhNQucfCsRFv+k2US29Accu7NVhg9b5JcrQMqrN4qIcl3S6VFLkKAlIL/o4kYZkKclkeZw42nDWjV6pjA1P03n8Y79KN3la7PbvKQtbBn4aki/tgzk8SceflxVnLO+Z5gCBC+LLNsZEcBUZO3qg+m07hO6744nu9m+reOvlRjALDglXLKf8MxB0Dqr1pL4s9pQcReFeI/ksNsWFxXg6+SFLsCPO7lIKkepUOaH8hDK74PwgcwZ9uyx+ux1zfymq8W0QMPKVha8aGOWHYedt1iq4R10f+TgRUo27MUGd3VbZuOQeNPoK6UQ2u5AAkg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199021)(40470700004)(46966006)(36840700001)(5660300002)(8676002)(8936002)(44832011)(336012)(86362001)(31696002)(83380400001)(2616005)(36860700001)(47076005)(82310400005)(81166007)(26005)(6512007)(6506007)(53546011)(82740400003)(356005)(186003)(40460700003)(478600001)(6486002)(40480700001)(41300700001)(316002)(70206006)(70586007)(4326008)(36756003)(31686004)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 08:28:22.8532 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c597b16d-db62-4369-d1a7-08db55e78325 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8975 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Minh, Thank you for this patch. This fix looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2023 08:08 am, Minh Nguyen wrote: > This helps to remove redundant assign for SmbiosHandle. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Minh Nguyen > --- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > index 7250da02b3ac..313129460d9c 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > @@ -213,8 +213,6 @@ SmbiosMiscGetLinkTypeHandle ( > return; > } > > - SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED; > - > for (Index = 0; Index < (*HandleCount); Index++) { > Status = mSmbiosMiscSmbios->GetNext ( > mSmbiosMiscSmbios,