From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v1 03/10] DynamicTablesPkg: Rename single char input parameter
To: PierreGondois <pierre.gondois@arm.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: Great Shelford, England, GB (217.140.106.53)
X-Originating-Platform: Windows Firefox 92
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Wed, 22 Sep 2021 08:20:37 -0700
References: <20210623110525.6171-4-Pierre.Gondois@arm.com>
In-Reply-To: <20210623110525.6171-4-Pierre.Gondois@arm.com>
Message-ID: <29996.1632324037457842477@groups.io>
Content-Type: multipart/alternative; boundary="w0kPBK1nmoaafhdByDDP"

--w0kPBK1nmoaafhdByDDP
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Pierre,

Thank you for this patch.

I have a minor comment.

On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:

>=20
> @return The ASCII code corresponding to x.

Can you update the documentation for the value returned, please? Also, desc=
ribe the value that would be returned in an error scenario.

With that changed,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

--w0kPBK1nmoaafhdByDDP
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Pierre,<br /><br />Thank you for this patch.<br /><br />I have a minor c=
omment.<br /><br />On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:<b=
r />
<blockquote>@return The ASCII code corresponding to x.</blockquote>
Can you update the documentation for the value returned, please? Also, desc=
ribe the value that would be returned in an error scenario.<br /><br />With=
 that changed,<br />Reviewed-by: Sami Mujawar &lt;sami.mujawar@arm.com&gt;<=
br /><br />Regards,<br /><br />Sami Mujawar

--w0kPBK1nmoaafhdByDDP--