From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.665.1589924140230430766 for ; Tue, 19 May 2020 14:35:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=IKvKnRnS; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: zT4nxUtBtvLwLL6oCeKGOfcCultrPs4B3kI1Wb5npQPXP3tQZfQWA2ax6irFWpIlWhRLy58EsM AkW2pl9OkQPA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 14:35:39 -0700 IronPort-SDR: jVha+WwgmqA6udagtOV9B7jGUvLT8uTAODNLcDJoAdv7j+ewFODgTliYEw4ddH157gG+xp/VJA eOOXoR9FswRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,411,1583222400"; d="scan'208";a="343276382" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga001.jf.intel.com with ESMTP; 19 May 2020 14:35:39 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 14:35:39 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX163.amr.corp.intel.com (10.22.240.88) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 14:35:39 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 14:35:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mIBsHuQ6OrvL3ji87KF/9TnBGxgjNntbTw/bnzdtEsS7M0QvZnmo9kR3DIut7sxyJNRr80rQbocTGUHrSPPUMW/97sK76E4gnuDvZeomox+fLZ9ur4OA3WQH8UuVYghBvWOkQyCxnPCHf9xDBiB4xlqFNjVUICzsep2b0/VhFY6BQFw5oNot8/F9PoT0cUg6q1chxTqQmMCXEFBQSgYg9s/lMFt0O1cpTZe9djWtQMe84VwQsi58AEHkW4w/r7EcplZqRkhpqHm4++LQF+3T/+Mi8ZdKkmMoNRVGVHELJ+yv1kdej9uyjV+eThf5GWFAzDJMCapfq49WcTCEtf9Ybg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8wSD7++MKCPQJcaLI8d57+KWCTxMIqP2BgNGKi+YgDo=; b=Kr1xraA7lXZ97A2VEIw8n9Ylc83LkI0AgpuwxZ8enRImUYnz1b3JpM5Kof0KNZ3434wBaHi/VyzzcVmEvcCIKlEe4wraBMYXA+H3xhcIv/gdAr2lLuF4Z0v9I9c4iKB+hQ306bYeoPNb/tjH1Xc8pfdwY0fEe8TDVu8g4L9IaBxbIH3RbXiIkODJ3Bl859JTgHypOE2+cVFPNW0XtkQyPQolRgEve7eQV6xCy7iMUXnx1wslYFTE5E7CbZNytr0ra8c21qEH4frUisI/FJX7jDX3bB8JM8pGYGvNg+uzEY8tJYt/pImOideuQmuq5r974G/HEuhA2i81Iwqqaxa9qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8wSD7++MKCPQJcaLI8d57+KWCTxMIqP2BgNGKi+YgDo=; b=IKvKnRnSTm8YwsrWg5ZpRM/MM9eD0SOtyuBurgv5ta7vb03xLj6XElSCZxpzSeD2qBRQt9eyixKzV8/7ywdTpaD/5vgWMZPcEEUxkBf+KkUFsQuVo2cfJpyz8eZ4ePfrkXwS9fK+ayhYB2PPB63rRNZ32XdN9w8hSbrwzWxnUXY= Received: from BL0PR11MB3489.namprd11.prod.outlook.com (2603:10b6:208:75::29) by BL0PR11MB3153.namprd11.prod.outlook.com (2603:10b6:208:6b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24; Tue, 19 May 2020 21:35:37 +0000 Received: from BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42]) by BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42%7]) with mapi id 15.20.3000.034; Tue, 19 May 2020 21:35:37 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "lersek@redhat.com" , Bret Barkelew , "spbrogan@outlook.com" , "rfc@edk2.groups.io" , "Kinney, Michael D" , "Leif Lindholm (Nuvia address)" , Andrew Fish Subject: Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Topic: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Index: AdYtq0vCPqbiMowAQbSbICPKq6X1VgAUtBSAAAF1CAAABCR2gAADxGeA//+OXQA= Date: Tue, 19 May 2020 21:35:37 +0000 Message-ID: <29D3C9C3-9090-4C73-8347-331BFF845DD0@intel.com> References: <01b731f7-80be-3671-de3d-18c6b288581f@redhat.com> In-Reply-To: <01b731f7-80be-3671-de3d-18c6b288581f@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/16.37.20051002 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdae8558-b942-41f0-3583-08d7fc3c9206 x-ms-traffictypediagnostic: BL0PR11MB3153: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +tcgx3+tquZtouSG42Soh1m9DnPCJLXGW/L6jQDalO3bT+AnLve5DtIUkVt8WbMS7Zs8LZvRCqh8027fN1b89mdbonXvIS09W3SYYccdbSRU4TqYZ42Mt50mPqVWBI8UzmRzbGPR4efy4w6HrKl39uWn1PIUOCvTcmaTtiSgX8z7V8vf01DfadgpxHBAIHjs+NPPghTaXnyYCHMf+Bf51AT+lNeLE5SpVZ1I5K5HYhABoVUt2SoIBaDV4CXyShvVir8G8awTaRKnkk4ntNLtZ8F/NwIaofv4A1pjqrr6qOucJE3eGvFkF39Xko3OQWbbxFZ6u9zTMV6K/dNXhj4PHmixtEfopCYKRBSj09WJmnCL9qpDggFH8R1vgoEQN9ajm9bZiLzVufNL2dNayPnsTOBm1mMdh6mET5KOXULczS+sAOGVCa8T9P8ogIuxbsCZwR1nnjJx4teRKjgnmSYSvVWK4S/JEAVI2EEuME9byrb3PV2mCgJ8+DgwEInEdHuX4zykcuxreOBDO3NBd5tCCQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3489.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(346002)(396003)(376002)(39860400002)(366004)(6512007)(8936002)(2616005)(316002)(6486002)(71200400001)(86362001)(110136005)(33656002)(2906002)(8676002)(6506007)(66556008)(66446008)(64756008)(66946007)(186003)(91956017)(26005)(66476007)(76116006)(36756003)(478600001)(5660300002)(966005)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: p/naJun5E5DvgXaNNI7vt3lJNiV+VSI8wpiDCrZc3GXuCKw07e9Ou9bccvm0Mik0sdml2sBZtvtnS00L4LW7V+8PsyOOZNc+KaemmllLffhpcqPAP0UbjlWAe+Hd558c94v9ukEH9sGmzNTLhk2imqb6KMsJgq4bHygcvyjSd4hMrgV84hxrunVKq0ARAoeOT1UAUdxrQPS1wX+nfFRf7+BLxCK0iGHmOrgsPVzQYIkjcpnKQZm2D+HwL0dh4ShUT0g5Y/XMWAHFlCPleQWbvDObe7dCRHZKlRVdes7tSA8LdMZyNy1DvDn+oPDR26ca1G0CxBefxyYe5/N26k5S9+sak+KnJwqhhxp1IPBYqSf25KuFnkl+FqlxAHyycPgiC++3iDsOvgXBtk2Sj4qXNXBcVihOcvSgZQy65ufEB+2rh1yLUHAPdgi3pvhzo3+I/ocJfSuNpDlWTHLPmOj5sgjzXoL55IHxKwDloyQZMggCS9BdSEPSQ/1yKMnIFqTg MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fdae8558-b942-41f0-3583-08d7fc3c9206 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 21:35:37.1144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dix+zEqAATdnLk6zUqojTG5N9Jr7pCfa/cqOEGR+LSuvycJHeDcB6u+i0CrvFoMEp68cN77nGsFR52gemxfWIAO5UFCurN/z9B/7nbURDkw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3153 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <935F3AEC81614A4785C6F3D77167BE94@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 SGkgTGFzemxvLA0KDQpJIHRoaW5rIGJvdGggbXlzZWxmIGFuZCBCcmV0IG1heSBoYXZlIGdvdHRl biBhIGxpdHRsZSBjaGlwcHkuIEkgdGhpbmsgYm90aCBvZiB1cyBhcmUgcGFzc2lvbmF0ZSBhYm91 dCBvdXIgd29yayBhbmQgdGhhdCBzaG93cyBpbiB0aGUgZGViYXRlLiBJIGFtIGhhcHB5IHRvIGZv cmdpdmUgQnJldCBhbmQgaG9wZWZ1bGx5IGhlIGlzIHdpdGggbWUgYXMgd2VsbC4NCg0KVGhhbmtz LA0KTmF0ZQ0KDQrvu79PbiA1LzE5LzIwLCAyOjIyIFBNLCAiZGV2ZWxAZWRrMi5ncm91cHMuaW8g b24gYmVoYWxmIG9mIExhc3psbyBFcnNlayIgPGRldmVsQGVkazIuZ3JvdXBzLmlvIG9uIGJlaGFs ZiBvZiBsZXJzZWtAcmVkaGF0LmNvbT4gd3JvdGU6DQoNCiAgICBPbiAwNS8xOS8yMCAyMTozNCwg QnJldCBCYXJrZWxldyB3cm90ZToNCiAgICA+IE5hdGUsIEkgYmVsaWV2ZSB5b3UgbWlzc2VkIFNl YW7DouKCrOKEonMgcG9pbnQuDQogICAgPiANCiAgICA+IEVhY2ggb25lIG9mIHRob3NlIHBhY2th Z2VzIHNob3VsZCBoYXZlIGJlZW4gYSBzZXBhcmF0ZSBQUi4NCg0KICAgIEFuZCB0aGVuIHdlIGdl dCB0byB3cmFuZ2xlIGludGVyLVBSIGRlcGVuZGVuY2llcy4NCg0KICAgIEV2ZW4gaWYgZ2l0aHVi LmNvbSBzdXBwb3J0cyB0aGF0LCBpdCdzIGEgaGVhdnktd2VpZ2h0IHRvb2wsIGFuZCBzaG91bGQN CiAgICBiZSB1c2VkIHNwYXJpbmdseS4gUGF0Y2hlcyBpbiBhIHBhdGNoIHNlcmllcyBhcmUgYWxt b3N0IGFsd2F5cw0KICAgIGludGVyLWRlcGVuZGVudCBpbiBzb21lIHdheSwgd2hpY2ggaW5kaWNh dGVzIHRoYXQgbWFueSBub3JtYWwgcGF0Y2ggc2V0cw0KICAgIHdvdWxkIGhhdmUgdG8gYmUgc3Bs aXQgaW50byBtdWx0aXBsZSBQUnMuDQoNCiAgICA+IEVyZ28sIG5vIGluZm9ybWF0aW9uIHdvdWxk IGhhdmUgYmVlbiBsb3N0IGluIHRoZSBzcXVhc2guDQogICAgPiANCiAgICA+IEFsc28sIGl0w6Li gqzihKJzIG5vdCBzbyBtdWNoIHRoYXQgd2UgKmNhbsOi4oKs4oSidCogbGVhcm4uIEl0w6Ligqzi hKJzIHRoYXQgd2UgY2hvb3NlIG5vdCB0by4gQXJvdW5kIGhlcmUsIGl0w6LigqzihKJzIGEgbWFy ayBvZiBwcmVzdGlnZSB0byBub3Qgb3BlbiBkb29ycyB3aXRoIHlvdXIgZmFjZSBpZiBpdCBzZWVt cyBsaWtlIHRoZXJlw6LigqzihKJzIGEgYmV0dGVyIHdheS4gTWFrZXMgaXQgZWFzaWVyIHRvIGZv Y3VzIG9uIHRoZSB3b3JrLg0KDQogICAgV3J0LiAib3BlbiBkb29ycyB3aXRoIHlvdXIgZmFjZSIs IHdoaWNoIEkgdW5kZXJzdGFuZCB0byBiZSBhIHJldG9ydCB0bw0KICAgIE5hdGUgYXNzb2NpYXRp bmcgcHJlc3RpZ2Ugd2l0aCBjb25mb3JtaW5nIHRvIHRoZSBjdXJyZW50IHdvcmtmbG93Og0KDQog ICAgSSB0aGluayB0aGUgZXhwcmVzc2lvbiBicmVha3MgdGhlIENvZGUgb2YgQ29uZHVjdDoNCg0K ICAgICAgaHR0cHM6Ly93d3cudGlhbm9jb3JlLm9yZy9jb2MuaHRtbA0KDQogICAgIkRvIG5vdCBp bnN1bHQgb3IgcHV0IGRvd24gb3RoZXIgcGFydGljaXBhbnRzIg0KDQogICAgKC4uLiBCZWZvcmUg YW55b25lIHN1Z2dlc3RzIHRoYXQgSSBkaWQgdGhlIHNhbWUgd2hlbiBJIGNhbGxlZA0KICAgIG1h aW50YWluZXJzICYgcGVvcGxlIGVuIGJsb2MgImlycmVwYWlyYWJseSBsYXp5IGFuZCB1bmRpc2Np cGxpbmVkIiBpbiBteQ0KICAgIHByZXZpb3VzIG1haWw6IHRoYXQncyBhIGZhY3QgYWJvdXQgaHVt YW5zLg0KDQogICAgUGVvcGxlIG9uIGF2ZXJhZ2UgcGVyZm9ybSB0aGUgbWluaW11bSBvZiB3b3Jr IHRoZXkgY2FuIGdldCBhd2F5IHdpdGgsDQogICAgZm9yIHNhdGlzZnlpbmcgcmVxdWlyZW1lbnRz IGFuZCBmb3IgcmVhY2hpbmcgZ29hbHMuIEl0J3MgbmF0dXJhbC4gVGhhdCdzDQogICAgd2h5IHdl IGhhdmUgdG8gc2V0IGhpZ2ggc3RhbmRhcmRzLiBTbyB0aGF0IGNvdmVycyAibGF6eSIuDQoNCiAg ICBBbmQgInVuZGlzY2lwbGluZWQiICg9IGlnbm9yaW5nIHJ1bGVzIGFuZCBnb29kIHByYWN0aWNl cykgaXMgZXZpZGVuY2VkDQogICAgZnJlcXVlbnRseSwgd2l0aCBmaXhlZCBCWnMgbGVmdCBvcGVu LCBwb3N0ZWQgcGF0Y2hlcyBub3QgcmVmZXJlbmNlZCBpbg0KICAgIHRoZSBCWnMgdGhleSBhZGRy ZXNzLCBCWnMgaWdub3JlZCAvIGxlZnQgdW4tdHJpYWdlZCBmb3IgbW9udGhzIGFuZA0KICAgIHll YXJzLCBwZW5kaW5nIHBhdGNoZXMgaWdub3JlZCBmb3Igd2Vla3MsIHJldmlld2VkIHBhdGNoZXMg bGVmdCB1bm1lcmdlZA0KICAgIGZvciBkYXlzIG9yIHdlZWtzLCBldGMuIEknbSBub3QgdGhyb3dp bmcgYXJvdW5kIGFjY3VzYXRpb25zLCBqdXN0DQogICAgc2hvd2luZyB0aGF0IG15IHN0YXRlbWVu dCB3YXMgZmFjdHVhbCwgaGFyZGx5IGFuIGluc3VsdC4gT1RPSCAib3Blbg0KICAgIGRvb3JzIHdp dGggeW91ciBmYWNlIiBpcyBmaWd1cmF0aXZlIHNwZWVjaCwgYW5kIEkgZG8gY29uc2lkZXIgaXQg YW4gaW5zdWx0LikNCg0KICAgIFRoYW5rcywNCiAgICBMYXN6bG8NCg0KDQogICAgDQoNCg0K