From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.28245.1669849372304026963 for ; Wed, 30 Nov 2022 15:02:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=T9hRyYoN; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 3713620B83C2; Wed, 30 Nov 2022 15:02:51 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3713620B83C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669849371; bh=QjWksjTmJ5GD0xE1cvwL5yjU2Gk4WjU/eAhFIIBSAhY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T9hRyYoNJF5M4nIKBJpdIaJCeF1Z0En4e4A3njQOMdQgBqdckWY90UmJCSA747EL+ //1SQvnOnTuThA+v3GCs8FU7gWsVjvjw5EtlX/i4igkTN0rpsBOOdEQ5mk/UHQL4p2 Sw1bte2qEak/+VaQs+p5tO0N8E0ngpgrT9pYb8kc= Message-ID: <29b99be2-6967-d200-77c8-8ceb058efa7e@linux.microsoft.com> Date: Wed, 30 Nov 2022 18:02:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Ray Ni , Zhiguang Liu References: <20221130211956.584-1-michael.d.kinney@intel.com> From: "Michael Kubacki" In-Reply-To: <20221130211956.584-1-michael.d.kinney@intel.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 11/30/2022 4:19 PM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4178 > > * Change GoogleTestLib class from private to public. > * Change UnitTestPersistenceLib class from private to public. > > Cc: Michael Kubacki > Cc: Sean Brogan > Cc: Ray Ni > Cc: Zhiguang Liu > Signed-off-by: Michael D Kinney > --- > .../Library/UnitTestPersistenceLib.h | 0 > UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec | 13 +++++++------ > 2 files changed, 7 insertions(+), 6 deletions(-) > rename UnitTestFrameworkPkg/{PrivateInclude => Include}/Library/UnitTestPersistenceLib.h (100%) > > diff --git a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h b/UnitTestFrameworkPkg/Include/Library/UnitTestPersistenceLib.h > similarity index 100% > rename from UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > rename to UnitTestFrameworkPkg/Include/Library/UnitTestPersistenceLib.h > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > index ed12f32009d8..14e387d63a0f 100644 > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > @@ -26,11 +26,16 @@ [Includes.Common.Private] > Library/CmockaLib/cmocka/include/cmockery > Library/GoogleTestLib/googletest/googletest > > -[LibraryClasses.Common.Private] > +[LibraryClasses] > ## @libraryclass Allows save and restore unit test internal state > # > - UnitTestPersistenceLib|PrivateInclude/Library/UnitTestPersistenceLib.h > + UnitTestPersistenceLib|Include/Library/UnitTestPersistenceLib.h > > + ## @libraryclass GoogleTest infrastructure > + # > + GoogleTestLib|Include/Library/GoogleTestLib.h > + > +[LibraryClasses.Common.Private] > ## @libraryclass Provides a unit test result report > # > UnitTestResultReportLib|PrivateInclude/Library/UnitTestResultReportLib.h > @@ -39,10 +44,6 @@ [LibraryClasses.Common.Private] > # > UnitTestBootLib|PrivateInclude/Library/UnitTestBootLib.h > > - ## @libraryclass GoogleTest infrastructure > - # > - GoogleTestLib|Include/Library/GoogleTestLib.h > - > [Guids] > gUnitTestFrameworkPkgTokenSpaceGuid = { 0x833d3aba, 0x39b4, 0x43a2, { 0xb9, 0x30, 0x7a, 0x34, 0x53, 0x39, 0x31, 0xb3 } } >