From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6273.1588077133565356421 for ; Tue, 28 Apr 2020 05:32:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A83731B; Tue, 28 Apr 2020 05:32:13 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7378F3F73D; Tue, 28 Apr 2020 05:32:12 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH v4 6/9] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-M platform To: Aditya Angadi , devel@edk2.groups.io Cc: thomas.abraham@arm.com, leif@nuviainc.com References: <20200414125208.2878-1-aditya.angadi@arm.com> <20200414125208.2878-7-aditya.angadi@arm.com> From: "Ard Biesheuvel" Message-ID: <29b9bee3-1704-07e4-c918-217bd558ce27@arm.com> Date: Tue, 28 Apr 2020 14:32:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200414125208.2878-7-aditya.angadi@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/14/20 2:52 PM, Aditya Angadi wrote: > Arm's RD-Daniel Config-M platform is built using 16 Neoverse cores and > connected to 8GB of RAM. Add initial platform support for this platform. > > Signed-off-by: Aditya Angadi > --- > Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf | 2 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4 ++ > Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.dsc | 51 ++++++++++++++++++++ > Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.fdf.inc | 10 ++++ > 4 files changed, 67 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf > index 783b915107ec..4ae0a796fb0c 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf > @@ -41,6 +41,8 @@ [Packages] > [FixedPcd] > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > + gArmPlatformTokenSpaceGuid.PcdCoreCount > + gArmPlatformTokenSpaceGuid.PcdClusterCount > > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum This belongs in a different patch, no? > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index d87fb2b5409f..a9d8d70f8667 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -70,6 +70,10 @@ > #define RD_N1_EDGE_CONF_ID 0x1 > #define RD_E1_EDGE_CONF_ID 0x2 > > +// RD-Daniel Platform Identification values > +#define RD_DANIEL_PART_NUM 0x78A > +#define RD_DANIEL_CFGM_CONF_ID 0x1 > + > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > #define SGI_PART_NUM_MASK 0xFFF > diff --git a/Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.dsc b/Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.dsc > new file mode 100644 > index 000000000000..a76a9ad715ad > --- /dev/null > +++ b/Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.dsc > @@ -0,0 +1,51 @@ > +# > +# Copyright (c) 2020, ARM Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +################################################################################ > +# > +# Defines Section - statements that will be processed to create a Makefile. > +# > +################################################################################ > +[Defines] > + PLATFORM_NAME = RdDanielCfgM > + PLATFORM_GUID = d301ac4e-0828-4cef-b754-34ca9b6781b5 > + PLATFORM_VERSION = 0.1 > + DSC_SPECIFICATION = 0x0001001B > + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > + SUPPORTED_ARCHITECTURES = AARCH64|ARM > + BUILD_TARGETS = NOOPT|DEBUG|RELEASE > + SKUID_IDENTIFIER = DEFAULT > + FLASH_DEFINITION = Platform/ARM/SgiPkg/SgiPlatform.fdf > + BOARD_DXE_FV_COMPONENTS = Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.fdf.inc > + BUILD_NUMBER = 1 > + > +# include common definitions from SgiPlatform.dsc > +!include Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > + > +################################################################################ > +# > +# Pcd Section - list of all EDK II PCD Entries defined by this Platform > +# > +################################################################################ > + > +[PcdsFixedAtBuild.common] > + # GIC Base Addresses > + gArmTokenSpaceGuid.PcdGicDistributorBase|0x30000000 > + gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x30140000 > + gArmSgiTokenSpaceGuid.PcdGicSize|0x200000 > + > + # ARM Cores and Clusters > + gArmPlatformTokenSpaceGuid.PcdCoreCount|1 > + gArmPlatformTokenSpaceGuid.PcdClusterCount|16 > + > +################################################################################ > +# > +# Components Section - list of all EDK II Modules needed by this Platform > +# > +################################################################################ > + > +[Components.common] > + Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf > diff --git a/Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.fdf.inc b/Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.fdf.inc > new file mode 100644 > index 000000000000..6a99bdbbbed1 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/RdDanielCfgM/RdDanielCfgM.fdf.inc > @@ -0,0 +1,10 @@ > +# > +# Copyright (c) 2020, ARM Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +# Per-platform additional content of the DXE phase firmware volume > + > + # ACPI support > + INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf >