From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <supreeth.venkatesh@arm.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=217.140.101.70; helo=foss.arm.com;
 envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org 
Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id E3E0E21CAD9BA
 for <edk2-devel@lists.01.org>; Tue, 16 Oct 2018 02:48:38 -0700 (PDT)
Received: by usa-sjc-mx-foss1.foss.arm.com (Postfix, from userid 105)
 id A24D93610; Tue, 16 Oct 2018 02:58:34 -0700 (PDT)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64D5434FA;
 Sun, 14 Oct 2018 19:25:13 -0700 (PDT)
Received: from [10.6.43.238] (bc-c3-3-14.eu.iaas.arm.com [10.6.43.238])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 764313F5B1;
 Sun, 14 Oct 2018 19:24:52 -0700 (PDT)
To: Eric Jin <eric.jin@intel.com>, edk2-devel@lists.01.org
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
References: <20181014015858.3852-1-eric.jin@intel.com>
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Message-ID: <29c1ba36-34e6-2f4a-7709-167d2ec69c6e@arm.com>
Date: Mon, 15 Oct 2018 03:24:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181014015858.3852-1-eric.jin@intel.com>
Subject: Re: [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Oct 2018 09:48:40 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>


On 10/14/2018 02:58 AM, Eric Jin wrote:
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
>   uefi-sct/SctPkg/Library/SctLib/Print.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Print.c b/uefi-sct/SctPkg/Library/SctLib/Print.c
> index c25aff11..e523073a 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Print.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Print.c
> @@ -2,7 +2,7 @@
>   
>     Copyright 2006 - 2015 Unified EFI, Inc.<BR>
>     Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.<BR>
> -  Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>
>   
>     This program and the accompanying materials
>     are licensed and made available under the terms and conditions of the BSD License
> @@ -676,7 +676,9 @@ _IPrint (
>     }
>   
>     ret = _Print (&ps);
> -  SctFreePool(ps.fmt.u.pw);
> +  if (fmt) {
> +    SctFreePool(ps.fmt.u.pw);
> +  }
>     return ret;
>   }
>